scummvm: Fix installation path and ini file #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
reviewed
Feb 22, 2024
ScummVM has changed the structure of the zip, the app is now in a folder inside the zip. Add a pre_install step to move the contents of this folder into the installation directory. Also fix the persistence of the ini file, it was being created as a folder and not a file. Fixes Calinou#1073 Calinou#1094
Calinou
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ScummVM has changed the structure of the zip, the app is now in a folder inside the zip. This adds a pre_install step to move the contents of this folder into the installation directory.
Also fix the persistence of the ini file, it was being created as a folder and not a file.
Closes #1073 and closes #1094