Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapping Model v2 #26

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from
Draft

Mapping Model v2 #26

wants to merge 5 commits into from

Conversation

jamierocks
Copy link
Member

@jamierocks jamierocks commented Sep 18, 2019

This pull request contains the work to overhaul Lorenz's mapping model, with some key aims:

  1. Increase code reuse through the model.
  2. Separate convenience functionality away, to make a clear distinction.
  3. Eliminate the necessity for the mapping model to be separate from its own implementation.
  4. Clean-up redundant code introduced in previous versions, and not identified.

My current goal is an API similar to the following:

        final MappingSet mappings = new MappingSet();
        final TopLevelClassMapping a = mappings.getOrCreate("a")
                .fields()
                    .getOrCreate("a").setDeobfName("name").getParent()
                    .getOrCreate("b").setDeobfName("age").getParent()
                    .getParent()
                .methods()
                    .getOrCreate("a", "()V").setDeobfName("run").getParent()
                    .getParent();

@jamierocks jamierocks added this to the 0.6.0 milestone Sep 18, 2019
@jamierocks jamierocks self-assigned this Sep 18, 2019
*
* @return The parent object
*/
P back();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having discussed this with @Minecrell, this will be renamed to #getParent().

@jamierocks jamierocks removed this from the 0.6.0 milestone Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant