Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Editor & ModManager & Core] Minimize button in SplashWindow and TaskWindow #338

Open
wants to merge 5 commits into
base: 1.0.6.4
Choose a base branch
from

Conversation

shoushou1106
Copy link
Contributor

Add button to minimize all window in SplashWindow and TaskWindow

SplashWindow

splashscreen

TaskWindow

taskwindow2

Also add drag to SplashWindow in Mod Manager and changed the title

@wannkunstbeikor
Copy link
Collaborator

i dont think those need to have a minimize button, especially the task window since u cant do anything will it appears anyways

@shoushou1106
Copy link
Contributor Author

i dont think those need to have a minimize button, especially the task window since u cant do anything will it appears anyways

It will block the desktop and cannot move.
some functions such as the apply mod or Export usage in LocalizedStringPlugin (usually editor is maximized when clicking export usage)

if u really think this is useless u can close this

@wannkunstbeikor
Copy link
Collaborator

It will block the desktop and cannot move.

are u sure cant u just press the frosty icon in the taskbar and then it will minimize the whole app

@shoushou1106
Copy link
Contributor Author

shoushou1106 commented Mar 2, 2024

press the frosty icon in the taskbar

no response on windows (maybe linux can)

@wannkunstbeikor
Copy link
Collaborator

will this make plugins which used the task window and were made with an older version incompatible?

@shoushou1106
Copy link
Contributor Author

shoushou1106 commented May 8, 2024

will this make plugins which used the task window and were made with an older version incompatible?

ok I'll test it, if possible please list a few.

@wannkunstbeikor
Copy link
Collaborator

rootinstanceplugin, meshsetplugin, etc.

@wannkunstbeikor
Copy link
Collaborator

most plugins use it if they do some longer operations

@shoushou1106
Copy link
Contributor Author

I tested most of the included plugins and they all work fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants