Skip to content

Fix Calculation of Compound Center of Masses #1822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix Calculation of Compound Center of Masses #1822

wants to merge 5 commits into from

Conversation

XeuTap
Copy link

@XeuTap XeuTap commented Apr 25, 2025 •
edited
Loading

The problem is described in the #1817

  • Reimplement the Center method of a compound.
  • Add a new utility method that inspects the compound for the highest-order topological shape.
  • Add test case.

XeuTap added 5 commits April 24, 2025 10:57
@XeuTap
Added a new method to help inspect compound shapes
fc1a8a3
@XeuTap
Extended Center of mass.
50d8af1 
It now supports an optional argument that helps correctly analyze the shape.
@XeuTap
Refactored Center method.
d4049c6 
Reimplemented Center of a Compound class
@XeuTap
Moved the compound-specific method implementation inside the child class
f6bff72
@XeuTap
Added new test-case.
c65378e 
The test case compares the center of mass of a compound consisting of faces with the expected value
@XeuTap XeuTap mentioned this pull request Apr 25, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@XeuTap