Call SetLocation to set top Assembly Location #1623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1623 +/- ##
=======================================
Coverage 94.91% 94.92%
=======================================
Files 28 28
Lines 6259 6263 +4
Branches 1271 1271
=======================================
+ Hits 5941 5945 +4
Misses 192 192
Partials 126 126 ☔ View full report in Codecov by Sentry. |
|
This seems more straightforward - prefer this over #1595 use of location multiplication? This PR creates an additional label. The display of the tree view of an exported step in OCCT CAD Assistant or FreeCAD shows this as an additional tree item. Just to mention the representation is slightly different but I think this is expected OCCT behavior. |
|
This looks cleaner, thanks @lorenzncode ! I moved the code back into _toCAF`. |
adam-urbanczyk
approved these changes
Jul 5, 2024
jmwright
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1594.
Alternative fix of1594.