Skip to content

Closes #786 Asymmetric Chamfer Error #1579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

kolod
Copy link

@kolod kolod commented May 1, 2024

Closes #786 Asymmetric Chamfer Error

cadquery uses random edge face when call into chamfer_builder.Add()

Fix uses face on which edge selected in chamfer_builder.Add() call

Example:

Workplane().box(10, 10, 10).faces("<X").chamfer(1, 2)

image

If both faces of the edge are selected chamfer now uses length2 for length to prevent unexpected behavior.

Example:

Workplane().box(10, 10, 10).faces("<Y or <X").edges("|Z").chamfer(1, 2)

image

kolod added 3 commits May 1, 2024 20:51

Verified

This commit was signed with the committer’s verified signature.
kolod Oleksandr Kolodkin
Add test for chamfer

Verified

This commit was signed with the committer’s verified signature.
kolod Oleksandr Kolodkin
Add test for chamfer

Verified

This commit was signed with the committer’s verified signature.
kolod Oleksandr Kolodkin
# Conflicts:
#	tests/test_chamfer.py
@kolod kolod changed the title fix #786 Asymmetric Chamfer Error Closes #786 Asymmetric Chamfer Error May 1, 2024

Verified

This commit was signed with the committer’s verified signature.
kolod Oleksandr Kolodkin
@adam-urbanczyk
Copy link
Member

Thanks for the PR, but looks like you still fail on mypy (annotations) and call show from the test which causes an error on azure. We'll probably need to discuss the proposed semantics too.

@adam-urbanczyk
Copy link
Member

@kolod do you intend to work on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Asymmetric Chamfer Error
2 participants