Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assembly top level location ignored #1594

Open
lorenzncode opened this issue May 28, 2024 · 0 comments · May be fixed by #1595 or #1623
Open

Assembly top level location ignored #1594

lorenzncode opened this issue May 28, 2024 · 0 comments · May be fixed by #1595 or #1623
Labels
assembly bug Something isn't working

Comments

@lorenzncode
Copy link
Member

In focusing on the color fix of PR #1157, I may have overlooked the importance of this comment as no tests had failed:

#1170 (comment)

There is a bug (regression) when a loc is specified at the top level. The test_step_export does not catch the failure because the top level locations are either (0, 0, 0) or applied to a nested assy.

You can see that in the simple_assy fixture the top level loc is ignored when visualizing the assembly in cq-editor (because it calls toCAF).

Another way to reproduce the issue is to compare the origin of an assembly as exported to STL (toCompound) vs STEP (toCAF) when a top level loc is specified. This points to an issue with toCAF.

The following example has no issue. The compound and assembly visualized in cq-editor show the same origin.

import cadquery as cq
from cadquery.occ_impl.shapes import *

# a table;  origin is bottom corner of table leg
w = 1200
l = 700
h = 800
t = 25

leg_w = 40
leg_l = 60

leg = box(leg_w, leg_l, h)
top = box(w, l, t)

assy = (
    cq.Assembly()
    .add(leg, name="leg0", loc=cq.Location((leg_w / 2, leg_l / 2, 0)))
    .add(leg, name="leg1", loc=cq.Location((w - leg_w / 2, leg_l / 2, 0)))
    .add(leg, name="leg2", loc=cq.Location((leg_w / 2, l - leg_l / 2, 0)))
    .add(leg, name="leg3", loc=cq.Location((w - leg_w / 2, l - leg_l / 2, 0)))
    .add(top, name="top", loc=cq.Location((w / 2, l / 2, h)))
)

comp = assy.toCompound()

show_object(comp, name="comp")
show_object(assy, name="assy")

Say I'd like to change the origin. Here a location is applied at the top level.
The compound and assembly results are now different. The result is not expected.

import cadquery as cq
from cadquery.occ_impl.shapes import *

# a table;  origin is centered under table
w = 1200
l = 700
h = 800
t = 25

leg_w = 40
leg_l = 60

leg = box(leg_w, leg_l, h)
top = box(w, l, t)

assy = (
    cq.Assembly(
        loc=cq.Location((-w / 2, -l / 2, 0))
    )  # origin is centered under table top
    .add(leg, name="leg0", loc=cq.Location((leg_w / 2, leg_l / 2, 0)))
    .add(leg, name="leg1", loc=cq.Location((w - leg_w / 2, leg_l / 2, 0)))
    .add(leg, name="leg2", loc=cq.Location((leg_w / 2, l - leg_l / 2, 0)))
    .add(leg, name="leg3", loc=cq.Location((w - leg_w / 2, l - leg_l / 2, 0)))
    .add(top, name="top", loc=cq.Location((w / 2, l / 2, h)))
)

comp = assy.toCompound()

show_object(comp, name="comp")
show_object(assy, name="assy")

image
@lorenzncode lorenzncode added bug Something isn't working assembly labels May 28, 2024
@lorenzncode lorenzncode linked a pull request May 28, 2024 that will close this issue
Open
@lorenzncode lorenzncode linked a pull request Jul 3, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
assembly bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@lorenzncode