Skip to content

Negation in compliance check #3981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Robin-Smets wants to merge 4 commits into
base: importer-rework
Choose a base branch
from
+12 −4
Draft

Negation in compliance check #3981

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
50674a7
implement negation of source and destination in matrix compliance check
Robin-Smets Nov 25, 2025
471e621
Merge branch 'importer-rework' into fix/negation-in-compliance-check
Robin-Smets Nov 26, 2025
1b1ff89
Merge branch 'importer-rework' into fix/negation-in-compliance-check
Robin-Smets Nov 28, 2025
a34884a
Merge branch 'importer-rework' into fix/negation-in-compliance-check
Robin-Smets Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions roles/lib/files/FWO.Compliance/ComplianceCheck.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,8 +587,8 @@ public static List<Management> GetRelevantManagements(GlobalConfig globalConfig,

private async Task<bool> CheckMatrixCompliance(Rule rule, ComplianceCriterion criterion, List<NetworkObject> resolvedSources, List<NetworkObject> resolvedDestinations)
{
Task<List<(NetworkObject networkObject, List<IPAddressRange> ipRanges)>> fromsTask = GetNetworkObjectsWithIpRanges(resolvedSources);
Task<List<(NetworkObject networkObject, List<IPAddressRange> ipRanges)>> tosTask = GetNetworkObjectsWithIpRanges(resolvedDestinations);
Task<List<(NetworkObject networkObject, List<IPAddressRange> ipRanges)>> fromsTask = GetNetworkObjectsWithIpRanges(resolvedSources, negated: rule.SourceNegated);
Task<List<(NetworkObject networkObject, List<IPAddressRange> ipRanges)>> tosTask = GetNetworkObjectsWithIpRanges(resolvedDestinations, negated: rule.DestinationNegated);

await Task.WhenAll(fromsTask, tosTask);

Expand Down Expand Up @@ -750,13 +750,21 @@ private bool CheckForForbiddenService(Rule rule, ComplianceCriterion criterion)
return ruleIsCompliant;
}

private static Task<List<(NetworkObject networkObject, List<IPAddressRange> ipRanges)>> GetNetworkObjectsWithIpRanges(List<NetworkObject> networkObjects)
private static Task<List<(NetworkObject networkObject, List<IPAddressRange> ipRanges)>> GetNetworkObjectsWithIpRanges(List<NetworkObject> networkObjects, string? fullRangeString = "0.0.0.0/0", bool negated = false)
{
List<(NetworkObject networkObject, List<IPAddressRange> ipRanges)> networkObjectsWithIpRange = [];

foreach (NetworkObject networkObject in networkObjects)
{
networkObjectsWithIpRange.Add((networkObject, ParseIpRange(networkObject)));
List<IPAddressRange> ranges = ParseIpRange(networkObject);

if (negated)
{
IPAddressRange fullRange = IPAddressRange.Parse(fullRangeString);
ranges = fullRange.Subtract(ranges);
}

networkObjectsWithIpRange.Add((networkObject, ranges));
}

return Task.FromResult(networkObjectsWithIpRange);
Expand Down
Loading