Sonar Cube Issue Tracker

.editorconfig

@@ -10,3 +10,7 @@ end_of_line = lf
 charset = utf-8
 trim_trailing_whitespace = false
 insert_final_newline = true
+
+[*.razor]
+indent_style = space
+indent_size = 4

.githook-templates/pre-commit.sample

@@ -0,0 +1,6 @@
+#!/usr/bin/env bash
+
+RUFF_PATH=.venv/bin/ruff
+
+$RUFF_PATH check --fix
+$RUFF_PATH format

.github/workflows/test-install.yml

@@ -1,14 +1,15 @@
-name: do test install
+name: Checks
 
 on:
   push:
     branches:
       - main
       - develop
       - importer-rework
-    paths-ignore:
-      - 'documentation/**'
-      - 'design/**'
+    # paths-ignore:
+    #   - 'documentation/**'
+    #   - 'design/**'
+    # do not ignore any paths as this breaks the github actions workflow
 
   pull_request:
     paths-ignore:
@@ -24,11 +25,10 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest]
-        # os: [ubuntu-latest, ubuntu-22.04]
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v6
 
-      - uses: actions/setup-dotnet@v4
+      - uses: actions/setup-dotnet@v5
         with:
           dotnet-version: '8.0.x'
 
@@ -38,9 +38,30 @@ jobs:
           ansible-playbook -e force_install=true site.yml -K
 
       - name: Running in GitHub actions requires testing puppeteer pdf creation separately
-        if: ${{ env.RUNNING_ON_GITHUB_ACTIONS }} == 'true'
+        if: ${{ env.RUNNING_ON_GITHUB_ACTIONS == 'true' }}
         run: |
           cd /home/runner/work/firewall-orchestrator/firewall-orchestrator/roles/tests-unit/files/FWO.Test
           dotnet restore
           dotnet build
           dotnet test --filter "Name=HtmlToPdfTest"
+
+
+  python-code-check:
+    name: Python Code Check
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v6
+
+      - uses: actions/setup-python@v6
+        with:
+          python-version: '3.11' 
+
+      - run: pip install -r roles/importer/files/importer/requirements.txt
+
+      - uses: astral-sh/ruff-action@57714a7c8a2e59f32539362ba31877a1957dded1
+
+      - run: pyright
+
+      - run: ruff check
+
+      - run: ruff format --exit-non-zero-on-format

.gitignore

@@ -1,9 +1,108 @@
 .vs/
-.idea/
+.vscode/launch.json
+.vscode/settings.local.json
 .test_data/
 roles/importer/venv/
 ansible_venv/
+*.todo
 **/.venv/
 **/__pycache__/
 **/*.pyc
 .vscode/launch.json
+
+# Created by https://www.toptal.com/developers/gitignore/api/jetbrains+iml
+# Edit at https://www.toptal.com/developers/gitignore?templates=jetbrains+iml
+
+### JetBrains+iml ###
+# Covers JetBrains IDEs: IntelliJ, RubyMine, PhpStorm, AppCode, PyCharm, CLion, Android Studio, WebStorm and Rider
+# Reference: https://intellij-support.jetbrains.com/hc/en-us/articles/206544839
+
+# User-specific stuff
+.idea/**/workspace.xml
+.idea/**/tasks.xml
+.idea/**/usage.statistics.xml
+.idea/**/dictionaries
+.idea/**/shelf
+
+# AWS User-specific
+.idea/**/aws.xml
+
+# Generated files
+.idea/**/contentModel.xml
+
+# Sensitive or high-churn files
+.idea/**/dataSources/
+.idea/**/dataSources.ids
+.idea/**/dataSources.local.xml
+.idea/**/sqlDataSources.xml
+.idea/**/dynamic.xml
+.idea/**/uiDesigner.xml
+.idea/**/dbnavigator.xml
+
+# Gradle
+.idea/**/gradle.xml
+.idea/**/libraries
+
+# Gradle and Maven with auto-import
+# When using Gradle or Maven with auto-import, you should exclude module files,
+# since they will be recreated, and may cause churn.  Uncomment if using
+# auto-import.
+# .idea/artifacts
+# .idea/compiler.xml
+# .idea/jarRepositories.xml
+# .idea/modules.xml
+# .idea/*.iml
+# .idea/modules
+# *.iml
+# *.ipr
+
+# CMake
+cmake-build-*/
+
+# Mongo Explorer plugin
+.idea/**/mongoSettings.xml
+
+# File-based project format
+*.iws
+
+# IntelliJ
+out/
+
+# mpeltonen/sbt-idea plugin
+.idea_modules/
+
+# JIRA plugin
+atlassian-ide-plugin.xml
+
+# Cursive Clojure plugin
+.idea/replstate.xml
+
+# SonarLint plugin
+.idea/sonarlint/
+
+# Crashlytics plugin (for Android Studio and IntelliJ)
+com_crashlytics_export_strings.xml
+crashlytics.properties
+crashlytics-build.properties
+fabric.properties
+
+# Editor-based Rest Client
+.idea/httpRequests
+
+# Android studio 3.1+ serialized cache file
+.idea/caches/build_file_checksums.ser
+
+### JetBrains+iml Patch ###
+# Reason: https://github.com/joeblau/gitignore.io/issues/186#issuecomment-249601023
+
+*.iml
+modules.xml
+.idea/misc.xml
+*.ipr
+
+# End of https://www.toptal.com/developers/gitignore/api/jetbrains+iml
+
+.idea/copilot*
+.idea/vcs.xml
+.idea/inspectionProfiles
+.idea/.gitignore

.pre-commit-config.yaml

@@ -0,0 +1,14 @@
+repos:
+- repo: https://github.com/astral-sh/ruff-pre-commit
+  # Ruff version.
+  rev: v0.14.8
+  hooks:
+    # Run the linter.
+    - id: ruff-check
+      args: [ --fix ]
+    # Run the formatter.
+    - id: ruff-format
+- repo: https://github.com/RobertCraigie/pyright-python
+  rev: v1.1.407
+  hooks:
+    - id: pyright

.sonarlint/FWO.json

@@ -0,0 +1,6 @@
+{
+    "sonarCloudOrganization": "cactusesecurity",
+    "projectKey": "CactuseSecurity_firewall-orchestrator",
+    "region": "EU",
+    "sonar.scanner.scanAll": false
+}