Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding SSVC v1.0.1 production schema to the CVE Record metrics block. #348

Open
wants to merge 4 commits into
base: feature-144-SSVC
Choose a base branch
from

Conversation

ccoffin
Copy link
Collaborator

@ccoffin ccoffin commented Oct 2, 2024

Added SSVC v1.0.1 production schema to the ssvc import directory. Updated CVE Record format to include SSVC v1.0.1 schema as one of the defined metrics.

@sei-vsarvepalli
Copy link
Contributor

Let me run a few tests and update this so the verify-json-validation does not fail.

@sei-vsarvepalli
Copy link
Contributor

I can reproduce the error from the ajv validate run. I cannot see the history of this failure when Workflow ran in the past to see if this has worked before.

@sei-vsarvepalli
Copy link
Contributor

I found a lot of gaps in this PR. Looks like the definitions are not cross-referenced from the ssvc-v1.0.1.json as well some of the field removals needed in schema-bundle.js file like delete metricProperties.ssvcV1_0_1.$id are also not there. I will look into it further give a full PR perhaps fixing these.

@sei-vsarvepalli
Copy link
Contributor

The commit 1b1ae14 still has some issues. It does not look like the file schema/docs/CVE_Record_Format_bundled.json is getting updated from the workflow file. This may have been done manually in the past?

The workflow also may need to be updated. Testing this in a couple of variants of node install - so please wait before merging..

Copy link
Contributor

@sei-vsarvepalli sei-vsarvepalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong -it will create an object of object like
"metrics": [ "ssvcV1_0_1": "SsvcdecisionpointgroupselectionSchema": {...}}

I am sending a fix to my repo and making an updated PR.

@sei-vsarvepalli
Copy link
Contributor

Moved these to be captured by #350

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants