Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move experimental instructions to their own file #20

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nwf
Copy link
Member

@nwf nwf commented Sep 2, 2019

And sort them by section of the appendix in the ISA doc.


/* >>> */
/* CRAM and CRAP (D.2) <<< */

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crap and cram are used by cheribsd and both are useful. I wonder if we should move them to non-experimental in the spec?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering that myself (and in fact have a comment in the docs to that effect). CHERI-RISC-V similarly no longer considers C{Get,Set}Flags experimental.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth deciding on a better name for one of those before promoting it in the ISA doc...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ISA doc calls them CRepresentableAlignmentMask (CRAM) and CRoundRepresentableLength (CRRL).

nwf added 2 commits September 6, 2019 15:46
And sort them by section of the appendix in the ISA doc.
@rmn30
Copy link
Collaborator

rmn30 commented Dec 16, 2019

Is this PR now obsolete?

@nwf
Copy link
Member Author

nwf commented Dec 16, 2019

I think we think that some of these things are still experimental; do you think the partition worthwhile? If so, I can update the PR.

@rmn30
Copy link
Collaborator

rmn30 commented Dec 17, 2019

I don't really mind. Is there a specific purpose to making the distinction here? Obviously in the manual they need to be separated and I suppose we might want to exclude them from proof in some circumstances...

@nwf
Copy link
Member Author

nwf commented Dec 17, 2019

It was mostly the latter I had in mind, yea. If they're not doing harm right now, I'm content to leave things well enough alone.

@bauereiss
Copy link
Contributor

In principle separating experimental instructions could be convenient for proof, but given that I am currently focusing on other architectures and nobody else is working on proofs of (Sail-)CHERI-MIPS at the moment AFAIK, I don't think there's a pressing need to change anything right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants