bsd.compat.mk: Error if NEED_COMPAT is set but not HAS_COMPAT #881
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrtc27
force-pushed
the
need-compat-error
branch
from
afbbf62 to
1c3c7d7
Compare
|
Maybe add "Reverts bfcbe6b" ? |
|
Oh, hm, presumably that means the bug still stands then :( |
|
Have you tested that with CheriBSD? IIRC our bsd.compat.mk includes src.opts.mk and so Andy's upstream change doesn't help us. Though perhaps we could get rid of that diff anyway. |
|
I verified that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation behind this is that, as Morello userspace is slowly merged in, we will have a period where only hybrid can be built, and we want to make sure that we never build NEED_COMPAT=CHERI programs as hybrid (such as cheribsdtest-purecap), which is something that accidentally ended up happing during the CHERI-RISC-V bring-up due to this bug. Instead we should make sure to add (MACHINE_ABI:Mpurecap || MK_COMPAT_CHERIABI) checks guarding such programs, not MACHINE_CPU:Mcheri.