-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
c18n: Port to RISC-V #2300
Open
dpgao
wants to merge
12
commits into
dev
Choose a base branch
from
c18n-riscv-port
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
c18n: Port to RISC-V #2300
+1,472
−183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpgao
force-pushed
the
c18n-riscv-port
branch
from
February 2, 2025 16:18
17dc0ed
to
3fabf7b
Compare
This avoids using otypes to protect the TCB data structure in the PLTGOTs of libraries.
When creating a new thread, the stack table for that thread is allocated and passed to libthr (via a struct) to be given to the new thread. Previously, the stack table is sealed when passed to libthr and unsealed (and installed) when the new thread starts. This commit allows the sealing to be optionally disabled with CHERI_LIB_C18N_NO_OTYPE.
Stack unwinding (in both setjmp/longjmp and C++ exceptions) requires handing a capability to the trusted stack to user code. This capability has previously been sealed with an otype. This commit adds the option to use subset sealing instead.
This was intended to seal function pointers where the otype corresponds to the signature of the function. The relevant compiler changes have not been implemented though.
/lib/c18n/* are also ported and built for CHERI-RISC-V.
dpgao
force-pushed
the
c18n-riscv-port
branch
from
February 2, 2025 20:42
3fabf7b
to
def5689
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces compile-time flag
CHERI_LIB_C18N_NO_OTYPE
to disable usage of otype sealing. This flag is set by default for RISC-V but not for Morello.