Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usr.bin/pmcstat: Provide a somewhat functional pmcstat -L #1513

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

arichardson
Copy link
Member

Previously pmcstat -L would return an error, now it returns the list of Neoverse-N1 counters. These are all valid, but we are still missing the Morello-specific counters here.

Previously pmcstat -L would return an error, now it returns the list of
Neoverse-N1 counters. These are all valid, but we are still missing the
Morello-specific counters here.
Copy link
Collaborator

@bsdjhb bsdjhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, can you still use Morello-specific counters by name after this change? The pmcstat code around the pmu-events stuff is rather confusing and I couldn't tell if you get the union if both sources (pmu-events and built-in tables) provide events, or if you only get the pmu-events.

@jrtc27
Copy link
Member

jrtc27 commented Oct 10, 2022

pmccontrol -L does work to list things today, kinda sad that pmcstat -L can't at least fall back to the built-in tables :(

@arichardson
Copy link
Member Author

pmccontrol -L does work to list things today, kinda sad that pmcstat -L can't at least fall back to the built-in tables :(

Hmm interesting - I was not aware of pmccontrol -L. It looks like this change overrides the list pmccontrol produces, so we can't see all the events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants