Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cheribsdtest tests to validate that stream IPC strips tags from capabilities #1027

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

rwatson
Copy link
Member

@rwatson rwatson commented Jun 20, 2021

A small set of tests attempting to validate that tagged capabilities have their tags stripped when transiting pipe IPC, local domain sockets, and loopback TCP sockets. Two message sizes are used: pointer-sized, and 8KiB, in attempts to exercise quite different paths in the pipe code. There are plenty of TODOs for potential future test additions.

@rwatson rwatson changed the base branch from master to dev June 20, 2021 17:26
@rwatson rwatson force-pushed the cheribsd_ipc_tagstripped_test branch from 05fa6e0 to 03e9077 Compare June 20, 2021 20:50
@rwatson
Copy link
Member Author

rwatson commented Jun 24, 2021

Tagging @brooks, @bsdjhb, @qwattash as they may be interested in this pull request.

Copy link
Member

@arichardson arichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testcase bodies can be shortened using the macros from cheribsdtest.h.
buffer is unused, I guess the intention was to store a capability inside the buffer?

@jrtc27
Copy link
Member

jrtc27 commented Jul 12, 2021

You somehow managed to do the wrong rebase :)

Tested IPC types include pipes, local domain sockets, and loopback
TCP.  Plenty of TODOs for future additions, such as further IPC
variations.
@rwatson rwatson force-pushed the cheribsd_ipc_tagstripped_test branch from 9536d8e to 4bf5401 Compare July 12, 2021 18:03
Not fully tested/debugged as .. it crashes the kernel in the
test_ipc_pipe_8k_tagstripped test.
…ting

stuck if the 8k send leads to the child blocking before all bytes have been
sent.
@paulmetzger paulmetzger deleted the cheribsd_ipc_tagstripped_test branch July 11, 2022 10:36
@jrtc27 jrtc27 restored the cheribsd_ipc_tagstripped_test branch July 11, 2022 14:54
@jrtc27 jrtc27 reopened this Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants