-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cheribsdtest tests to validate that stream IPC strips tags from capabilities #1027
Open
rwatson
wants to merge
6
commits into
dev
Choose a base branch
from
cheribsd_ipc_tagstripped_test
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+282
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
05fa6e0
to
03e9077
Compare
arichardson
reviewed
Jun 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testcase bodies can be shortened using the macros from cheribsdtest.h
.
buffer
is unused, I guess the intention was to store a capability inside the buffer?
You somehow managed to do the wrong rebase :) |
Tested IPC types include pipes, local domain sockets, and loopback TCP. Plenty of TODOs for future additions, such as further IPC variations.
9536d8e
to
4bf5401
Compare
arichardson
reviewed
Jul 12, 2021
arichardson
reviewed
Jul 12, 2021
Not fully tested/debugged as .. it crashes the kernel in the test_ipc_pipe_8k_tagstripped test.
…eing sent and received.
arichardson
reviewed
Jul 14, 2021
…ting stuck if the 8k send leads to the child blocking before all bytes have been sent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small set of tests attempting to validate that tagged capabilities have their tags stripped when transiting pipe IPC, local domain sockets, and loopback TCP sockets. Two message sizes are used: pointer-sized, and 8KiB, in attempts to exercise quite different paths in the pipe code. There are plenty of TODOs for potential future test additions.