Adds the everest command #408
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Member
|
Many thanks for this contribution! Please could you check the lint & type checking errors (mypy & ruff) that have been provided in the PR checks and attempt to fix them. I will be able to sort them in the next couple of days if you don't get to them. The container build check is not a problem with this PR and is instead due to the problem discussed in #409. |
MattyTheHacker
had a problem deploying
to
publish
GitHub Actions
Failure
MattyTheHacker
had a problem deploying
to
publish
GitHub Actions
Failure
MattyTheHacker
had a problem deploying
to
publish
GitHub Actions
Failure
MattyTheHacker
had a problem deploying
to
publish
GitHub Actions
Failure
MattyTheHacker
force-pushed
the
donian_everest_branch
branch
from
2bfbcef to
bf65898
Compare
MattyTheHacker
had a problem deploying
to
publish
GitHub Actions
Failure
Member
|
Hi @Donian960 are you still working on this? If not I'll go ahead and close the PR and re-assign the issue. |
Contributor
Author
|
@CarrotManMatt Ah no I've not been working on it, feel free to re-assign |
CarrotManMatt
assigned
MattyTheHacker and
Donian960 and unassigned
Donian960 and
MattyTheHacker
Member
|
Cheers for letting us know. Seems like @MattyTheHacker was making some changes, so i'll do some branch shenanigans to move it into our repo. Thanks for the initial contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a command /everest that takes in attributes for
course(str, "bsc" or "msci", not case dependent),year(int, 1 to 4) andvalue(float, what % of the module an assignment is worth) and calculates how many steps of Mt. Everest that assignment was worth (44,250 steps total).For example if someone is on the msci course and 3rd year and their assignment was worth 50% of the module then the assignment is worth 1475 steps (0.5 * 1/6 * 0.4 * 44250)