Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add NPM publishing on Travis-CI #233

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nschonni
Copy link
Member

Closes #231

@nschonni nschonni requested a review from XhmikosR July 28, 2017 06:18
@XhmikosR
Copy link
Member

Your patch no longer tests on v0.10 which is supported in theory. Otherwise it should be changed in package.json and any other places.

Other than that, it's your call if you want to do this automatically. :)

@nschonni
Copy link
Member Author

I can add it back, but it did EOL back in October

@XhmikosR
Copy link
Member

Just to be clear, I don't care about 0.10 :) Just make sure the drop is proper and mentioned everywhere.

@XhmikosR
Copy link
Member

@nschonni: my only 2 concerns:

  1. I'd go with numbers instead of aliases because it's clearer which is what
  2. We need to update package.json engines property for the node < 4 drop (and any other places)

@nschonni
Copy link
Member Author

@frvge sorry, I just saw that you've been landing stuff again :)
I'll try and fix this up and do the same for CSSLint so i'm not a blocker for getting stuff out.
/cc @stubbornella

@frvge
Copy link
Contributor

frvge commented Dec 28, 2017

@nschonni , can we get this one out the door in 2018?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants