Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Nextcloud update #1995

Closed
wants to merge 21 commits into from
Closed

Conversation

kkmattil
Copy link
Contributor

Proposed changes

Briefly describe the changes you've made here. Remember to add a link to the preview page of your branch.

Checklist before requesting a review

  • I have followed the instructions in the Contributing and Styleguide documents.
  • My pull request passes all tests.
  • I have included a link to the appropriate preview page (select your branch from the list).

@rkronberg
Copy link
Collaborator

rkronberg commented Feb 15, 2024

@kkmattil If I may suggest, perhaps you could create a PR for these changes from a fresh branch of Docs? Now it seems to be from a fork of your own which is not really up to date (or has been forked from some other branch than master). There are a lot of other commits here, which I think are unrelated to the Nextcloud update, or am I wrong?

It would certainly expedite the review process to only have the relevant stuff in the PR! :)

@rkronberg rkronberg changed the title Nextcloud update WIP: Nextcloud update Feb 15, 2024
@joonas-somero
Copy link
Member

[...] There are a lot of other commits here, which I think are unrelated to the Nextcloud update, or am I wrong?

You are not wrong. The commits seem to be from #1969.

@kkmattil
Copy link
Contributor Author

kkmattil commented Feb 15, 2024 via email

@kkmattil kkmattil closed this Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants