-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Nextcloud update #1995
WIP: Nextcloud update #1995
Conversation
Including tasks for common operations and default LF for line endings
@kkmattil If I may suggest, perhaps you could create a PR for these changes from a fresh branch of Docs? Now it seems to be from a fork of your own which is not really up to date (or has been forked from some other branch than master). There are a lot of other commits here, which I think are unrelated to the Nextcloud update, or am I wrong? It would certainly expedite the review process to only have the relevant stuff in the PR! :) |
You are not wrong. The commits seem to be from #1969. |
Hi
I taught that I was using a fresh branch of Docs, but apparently I wasn't.
Should I do something else than "git pull" to get my local version up to date?
Regards,
Kimmo M.
…-----------------------------------------------------------------------
Kimmo Mattila
Sovellusasiantuntija / Application specialist
CSC - Tieteen tietotekniikan keskus Oy/CSC - IT Center for Science Ltd.
PO BOX 405, FI-02101 Espoo, Finland
lat. 60° 10.7' long. 24° 49.5'
Tel. +358 9 457 2708
From: "Rasmus Kronberg" ***@***.***>
To: "CSCfi/csc-user-guide" ***@***.***>
Cc: "Kimmo Mattila" ***@***.***>, "Mention" ***@***.***>
Sent: Thursday, February 15, 2024 8:26:21 AM
Subject: Re: [CSCfi/csc-user-guide] Nextcloud update (PR #1995)
[ https://github.com/kkmattil | @kkmattil ] If I may suggest, perhaps you could create a PR for these changes from a fresh branch of Docs? Now it seems to be from a fork of your own which is not really up to date (or has been forked from some other branch than master). There are a lot of other commits here as well, which I think are unrelated to the Nextcloud update, or am I wrong?
It would certainly expedite the review process to only have the relevant stuff in the PR! :)
—
Reply to this email directly, [ #1995 (comment) | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/AA5PHMYFFTGDX3OUBF5UEQTYTWTA3AVCNFSM6AAAAABDIOYB2GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBVGQ2DIMRWG4 | unsubscribe ] .
You are receiving this because you were mentioned. Message ID: <CSCfi/csc-user-guide/pull/1995/c1945444267 @ github . com>
|
Proposed changes
Briefly describe the changes you've made here. Remember to add a link to the preview page of your branch.
Checklist before requesting a review