Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add min and max quantity query params to list items API #112

Merged
merged 3 commits into from
May 3, 2023
Merged

Conversation

prr79
Copy link
Contributor

@prr79 prr79 commented May 3, 2023

Addresses issue #88

ip:8080/shopcarts/10/items?quantity=3&min_quantity=1&max_quantity=2 - would ignore min and max quantities and just query for items with quantity=3
ip:8080/shopcarts/10/items?min_quantity=1 - query for items with quantity >= 1
ip:8080/shopcarts/10/items?max_quantity=2 - query for items with quantity <= 2
ip:8080/shopcarts/10/items?min_quantity=1&max_quantity=2 - query for items with quantity between 1 and 2.

@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Merging #112 (68344bf) into master (bfdf90f) will increase coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
+ Coverage   97.45%   97.57%   +0.12%     
==========================================
  Files           8        8              
  Lines         393      413      +20     
==========================================
+ Hits          383      403      +20     
  Misses         10       10              
Impacted Files Coverage Δ
service/routes.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@SFARL SFARL merged commit fe2af75 into master May 3, 2023
@SFARL SFARL deleted the prr-88 branch May 3, 2023 13:26
@SFARL
Copy link
Collaborator

SFARL commented May 3, 2023

IBM Cloud toolchain: Delivery Pipeline deployed shopcarts to nyu-devops, including commit fe2af75

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants