Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also added some documentation and made a few refactors to make the code more legible/understandable.
The problem was that the recursive steiner tree building process required both sides of the edge in the graph to be "out of order" (aka
in rec_nodes
), but in reality, there will be at least 1 node inusable_nodes
that is not inrec_nodes
which is needed to combine the two subgraphs.In addition to this, the vertices of the architecture are assumed to be in a post-order DFT labeling and the architecture still requires a
reduce_order
that has the order in which the vertices can be removed without disconnecting the graph (largest vertex first). I will write the algorithms to do this automatically later.