fixed performance notes negative tick durations bug

[huispaty]

The fix modifies note_off_tick and duration_tick in a performance note array (in a somewhat inelegant way due to the fixed and default pps/pqs). If the notes used to generate the note array have an (adjusted) tick_off value, that value is used; otherwise, the previous approach is maintained.

[CarlosCancino-Chacon]

Thanks for the bug fix! I have just a minor comment regarding raising a deprecation warning for renaming one of the functions (for compatibility reasons), and a couple of questions.

[CarlosCancino-Chacon]

Perhaps we can add a deprecation warning for the old name of the method? I image that this might not be a method commonly used on its own, but otherwise it could break compatibility.

Maybe we can add something like this:

import warnings

def adjust_offsets_w_sustain(*args, **kwargs):
    """Deprecated function! use adjust_note_offsets_with_sustain instead."""
    warnings.warn(
        "`adjust_offsets_w_sustain` is deprecated and will be removed in a future version. Use `adjust_note_offsets_with_sustain` instead.",
        DeprecationWarning,
        stacklevel=2,
    )
    return adjust_note_offsets_with_sustain(*args, **kwargs)

[CarlosCancino-Chacon]

Is there a reason to adjust the timing of the notes before assigning the ids? (this is a question rather than a comment on this change 😉)

[CarlosCancino-Chacon]

Do you think it might be worthwhile to add another "layer" to avoid negative durations by e.g., clipping negative durations at this point (e.g., duration_tick = max(duration_tick, 0)). On the other hand this might introduce some issues that might be hard to debug.