Version 1.6.0

[sildater]

PR for version 1.6.0

This new version addresses multiple changes, bug fixes and new features:

New features

• Measure refactor for musicxml, match, midi, note array to part in Measure refactor match/midi/musicxml #376
• Measure feature Measure feature #377
• Clef feature Clef feature #382
• Clef map Add clef map #384 Clef map testing #396
• Stem direction Stem Direction Support #392
• Support for cross staff voices in mei Cross staff voices #397

Bug fixes

• get_time_maps_from_alignment fix issue 358 #360
• correct metrical strength features fix bug, update documentation #364
• correct offsets for tied notes Corrected Offsets for tied notes. #366
• fix import issue Fix import for issue 348 #368
• fix kern parsing Kern fixes (parsing editorials) #370
• correct symbolic note duration New solution for estimate_symbolic_duration #372
• fix tuplet bug Relax assertion tuplet #387

Other Changes

• add check for empty note array add check for empty note array #361
• improve documentation improve documentation performance note_array #362 fix bug, update documentation #364
• remove default voice estimation estimate_voice_info now default to false #373
• add warning Fix issue 378 #379
• remove ordering in musicxml export patch issue 390 #391

Todo

• some PRs are still to be merged
• set new version

[manoskary]

Updated Merge Report

below the updated notes for this PR to include most recent changes

PR for version 1.6.0

This new version addresses multiple changes, bug fixes and new features:

New features

• Measure refactor for musicxml, match, midi, note array to part in Measure refactor match/midi/musicxml #376
• Measure feature Measure feature #377
• Clef feature Clef feature #382
• Clef map Add clef map #384 Clef map testing #396
• Stem direction Stem Direction Support #392
• Support for cross staff voices in mei Cross staff voices #397
• Improved parsing of Kern scores Updates on kern support #413
• Fixed import for performance pedal Performance pedal fix #399
• Tick Units are now supported for pianoroll creation add tick units #412
• Scores can be loaded directly for URL Load Scores from URL #404
• Support for invisible objects in musicxml import Add a parameter to ignore invisible objects when parsing MusicXML files #401
• Support for Fingering annotations in MusicXML and MEI import/export Support for Fingering Annotations and Markings. #403

Bug fixes

• Corrected get_time_maps_from_alignment fix issue 358 #360
• Corrected metrical strength features fix bug, update documentation #364
• Corrected offsets for tied notes Corrected Offsets for tied notes. #366
• Fixed import issue Fix import for issue 348 #368
• Fixed Kern parsing Kern fixes (parsing editorials) #370
• Duration of Chord Notes equal duration for all chord notes #418
• Corrected symbolic note duration New solution for estimate_symbolic_duration #372
• Fixed tuplet bug Relax assertion tuplet #387
• Addressed sorting for enharmonic notes Sort exported notes by step when same midi_pitch #407
• Fixes eq bug on performed notes Fix issue #421 #422
• Fixed timing-tempo change bug adjust timing of note events according to tempo changes #427

Other Changes

• Added check for empty note array add check for empty note array #361
• Improved documentation improve documentation performance note_array #362 fix bug, update documentation #364
• Removed default voice estimation estimate_voice_info now default to false #373
• Added warning Fix issue 378 #379
• Removed ordering in musicxml export patch issue 390 #391
• Improved Fingering parsing in MusicXML that could result to errors Fix Issue #414 #416
• Replaced Deprecated Scipy Function Replaced deprecated scipy derivative #417
• Improved support for input and export in musicxml tuplet object
• New option to force add new segments option to to force new segments in add_segments #410

[huispaty]

This release PR brings several valuable features and improvements:

• Measure feature with full I/O support for MusicXML, MIDI, Match, and Note Array
• Clef feature and an updated feature map
• Stem direction processing
• Cross-voice processing in MEI

Additionally, this release includes various bug fixes and enhancements.

[leleogere]

Support for invisible objects in musicxml import #401

There might be issues with this PR in some rare cases: as a parsing error can happen when there are invisible objects that are part of some kind of "group". For example, in #419, the parser crashes because a single note of a chord is invisible. I did not test with other types of "groups" (tuplets, beamings), but I guess it might happen too, depending on how the parser works. As long as Partitura does not have a proper way of dealing with invisible objects (such as an invisible attribute on TimedObject), I think we could add at least a warning when the user passes ignore_invisible_objects=True to load_musicxml to inform them that it might sometimes lead to parsing errors for unusual musicxml files.

Note that when ignore_invisible_objects is False (the default), the parsing works as expected as before.

[CarlosCancino-Chacon]

The pull request seems very comprehensive. I left a small comment about using ensure_notearray instead of using the note_arrray method of an object, but this should be an easy fix

This reviewer is now the assignee therefore review is dismissed and assigned to somebody else.

[manoskary]

Hi there! I've incorporated the suggested changes and made the necessary updates. We're now aiming for a new release on Thursday, February 27th. Please feel free to share any additional comments or ideas until then. Thanks for your great feedback!

[huispaty]

"Hi! I reduced my second review on the new invisible object warning since the other updates were either my own or related to package metadata. Everything looks good to me—I think we're ready to release!"