Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update screen mirroring in Infotainment.vspec #699

Closed
wants to merge 1 commit into from
Closed

Update screen mirroring in Infotainment.vspec #699

wants to merge 1 commit into from

Conversation

spshin3
Copy link
Contributor

@spshin3 spshin3 commented Dec 13, 2023

Resolve "erik's comment" and a DCO problem from PR #686 .

@erikbosch erikbosch added the Status:Review Please review/discuss contents label Dec 19, 2023
@erikbosch
Copy link
Collaborator

This PR addresses screen mirroring, we have since before smartphone projection, see below.

I am no expert in this area, but what is the difference? I.e. what use-cases and technologies are supposed to be covered by the screen mirroring signals? Just want to make sure that we do not duplicate functionality. Is it intended for Chromecast and similar "one way" technologies? (Android Auto, Apple Carplay and MirrorLink already mentioned in projection signals).

If it concerns different but similar technologies that cannot be used in parallel we may continue just extending the SmartphoneProjection branch as needed


SmartphoneProjection:
  type: branch
  description: All smartphone projection actions.

SmartphoneProjection.Active:
  datatype: string
  type: actuator
  allowed: [ 'NONE', 'ACTIVE',  'INACTIVE' ]
  description: Projection activation info.
  comment: NONE indicates that projection is not supported.

SmartphoneProjection.Source:
  datatype: string
  type: actuator
  allowed: ['USB', 'BLUETOOTH', 'WIFI']
  description: Connectivity source selected for projection.

SmartphoneProjection.SupportedMode:
  datatype: string[]
  type: attribute
  allowed: [ 'ANDROID_AUTO', 'APPLE_CARPLAY', 'MIRROR_LINK', 'OTHER' ]
  description: Supportable list for projection.


SmartphoneScreenMirroring.Resolution:
datatype: string
type: attribute
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the physical resolution offered by the HMI, i.e. static, or is it the current resolution as agreed by receiver (Infotainment) and sending device?

One can in general discuss if the ScreenMirroring/SmartphoneProjection signals shall be sensor or actuators. I assume the actual setup/connection/pairing not will be managed by VSS so that VSS only is used for showing current status, and then all could be "sensors", but I have no problems calling them "actuators" either, in the end it all depends on implementation. But if this signal represents current resolution rather than static/constant display resolution the it should be "sensor" rather than "attribute".

@erikbosch erikbosch added the Status:Rework Committer must refactor or address comments label Jan 16, 2024
@erikbosch erikbosch marked this pull request as draft January 30, 2024 12:40
@erikbosch
Copy link
Collaborator

@spshin3 - I converted this PR to a draft as I see that some rework is needed. For example calrifying the different between "SmartphoneScreenMirroring" and "SmartphoneProjection". Will you have time to continue work on this PR in the next weeks?

@spshin3 spshin3 marked this pull request as ready for review April 10, 2024 19:27
@spshin3 spshin3 closed this Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status:Review Please review/discuss contents Status:Rework Committer must refactor or address comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants