Adding mutex locks in cache to prevent race conditions #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MaartendeKruijf how do we test this? |
|
@MaartendeKruijf is this enough or should we do some more in-depth testing and such? |
|
@lucamrgs let met check |
MaartendeKruijf
force-pushed
the
feature/184-prevent-reporter-race-conditions
branch
from
35a59ac
to
c0557a9
Compare
MaartendeKruijf
requested changes
Aug 2, 2024
| @@ -85,7 +68,43 @@ func (cacheReporter *Cache) addExecution(newExecutionEntry cache_report.Executio | |||
| return nil | |||
| } | |||
|
|
|||
| func (cacheReporter *Cache) GetExecutions() ([]cache_report.ExecutionEntry, error) { | |||
| cacheReporter.mutex.Lock() | |||
There was a problem hiding this comment.
I would gaurd the most critical sections in getExecutions and addExecutions. Also then just use a go routine to let the decomposer not wait on any mutex.
MaartendeKruijf
force-pushed
the
feature/184-prevent-reporter-race-conditions
branch
from
eb52553
to
3b83bde
Compare
|
@MaartendeKruijf both requested changes are implemented |
MaartendeKruijf
force-pushed
the
feature/184-prevent-reporter-race-conditions
branch
from
6317870
to
818cad4
Compare
MaartendeKruijf
approved these changes
Aug 8, 2024
|
|
||
| // Lock | ||
| cacheReporter.mutex.Lock() | ||
| for _, executionEntryKey := range cacheReporter.fifoRegister { |
There was a problem hiding this comment.
user defer unlock if an error occurs the mutex will not be unlocked.
MaartendeKruijf
deleted the
feature/184-prevent-reporter-race-conditions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.