feat: Add animation on scroll in about-us page. #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cops ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This uses scrollTrigger plugin of gsap for adding animation to about-us content. Co-authored-by: Manan Rathi <[email protected]> Signed-off-by: Somesh Ranjan <[email protected]>
|
@somesh202 updates on this |
|
do one more thing for this PR let's get rid of |
|
Just add gsap and remove nuxt-gsap-module from config |
somesh202
force-pushed
the
anim-about-us
branch
from
5d8720b
to
d215318
Compare
somesh202
force-pushed
the
anim-about-us
branch
from
d215318
to
ce9a415
Compare
king-11
requested changes
Aug 19, 2022
| @@ -66,14 +66,14 @@ | |||
|
|
|||
| <script lang="ts"> | |||
| import { defineComponent } from '@nuxtjs/composition-api' | |||
| import { gsap } from 'gsap' | |||
There was a problem hiding this comment.
gsap isn't there in package.json
| "nuxt": "^2.15.8", | ||
| "nuxt-gsap-module": "^1.7.1", |
|
@king-11 Is the deploy preview of the About Us page the intended animation? The scroll trigger behavior seemed a little off🤔. |
|
The pinning might feel a bit off but yeah it's intended as done by @somesh202 . There is one issue though on mobile view the trailer and about us last card overlap |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add animation on scroll in about-us page:
This uses scrollTrigger plugin of gsap for adding animation to about-us content.
Fixes
Fixes #[issue number] by @[issue author]
Types of changes
Checklist: