Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Optimzing Search #47

Merged
merged 1 commit into from
Sep 26, 2021
Merged

Conversation

JeeveshGarg
Copy link
Collaborator

Fixes #39

@king-11
Copy link
Member

king-11 commented Sep 12, 2021

How is it different from the last one just wanted to know before reviewing... Also you should have made commits to the last PR only shouldn't have created multiple PRs for same thing.

@JeeveshGarg
Copy link
Collaborator Author

JeeveshGarg commented Sep 12, 2021

now i get to know difference between select_related and prefetch_related and your statement "Its for use cases when we will, later on, try to access a field"

About new PR, in earlier PR i got issues in env setup, their is correction in setup instruction in readme file ig, that why i setup project from scratch again.

@king-11
Copy link
Member

king-11 commented Sep 12, 2021

Cool I will try to give you a review by tomorrow or day after tomorrow thanks for taking up the issue 😄

@king-11
Copy link
Member

king-11 commented Sep 25, 2021

Hey @JeeveshGarg I think we can hasten up the process of reviewing if you can explain me your changes in a meet... So can you join the VC at 3PM Today?

@JeeveshGarg
Copy link
Collaborator Author

Okay.

for teamserializer use join query on team leaders and members
HackathonTeamView,TeamView,SubmissionRUDView
@JeeveshGarg
Copy link
Collaborator Author

@king-11 PTAL, will make separate PR for issue #38 (with migration).

@king-11
Copy link
Member

king-11 commented Sep 25, 2021

@JeeveshGarg you still have to push in the migrations lemme know when you are done with that

@king-11 king-11 added the enhancement New feature or request label Sep 26, 2021
Copy link
Member

@king-11 king-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻 good job

@king-11 king-11 merged commit 6c9417a into COPS-IITBHU:development Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimzing Search on Foreign Keys
2 participants