-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Optimzing Search #47
Conversation
How is it different from the last one just wanted to know before reviewing... Also you should have made commits to the last PR only shouldn't have created multiple PRs for same thing. |
now i get to know difference between select_related and prefetch_related and your statement "Its for use cases when we will, later on, try to access a field" About new PR, in earlier PR i got issues in env setup, their is correction in setup instruction in readme file ig, that why i setup project from scratch again. |
Cool I will try to give you a review by tomorrow or day after tomorrow thanks for taking up the issue 😄 |
Hey @JeeveshGarg I think we can hasten up the process of reviewing if you can explain me your changes in a meet... So can you join the VC at 3PM Today? |
Okay. |
for teamserializer use join query on team leaders and members HackathonTeamView,TeamView,SubmissionRUDView
b788b90
to
04dd1e3
Compare
@JeeveshGarg you still have to push in the migrations lemme know when you are done with that |
b82394c
to
04dd1e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻 good job
Fixes #39