Skip to content

Commit

Permalink
Upgrade spring gem (#2113)
Browse files Browse the repository at this point in the history
## 🎫 Ticket

no ticket
## 🛠 Changes

[Spring](https://github.com/rails/spring) (a gem for speeding up tests)
and spring-watcher-listen updated

## ℹ️ Context for reviewers

Old version of spring was blocking `rails console` from running.
Update just in "development" stanza, so should not impact production

## ✅ Acceptance Validation

Tests pass, can run rails console

## 🔒 Security Implications

- [ ] This PR adds a new software dependency or dependencies.
- [ ] This PR modifies or invalidates one or more of our security
controls.
- [ ] This PR stores or transmits data that was not stored or
transmitted before.
- [ ] This PR requires additional review of its security implications
for other reasons.

If any security implications apply, add Jason Ashbaugh (GitHub username:
StewGoin) as a reviewer and do not merge this PR without his approval.
  • Loading branch information
jdettmannnava authored Apr 3, 2024
1 parent 2239ecf commit d87f9c5
Show file tree
Hide file tree
Showing 8 changed files with 17 additions and 17 deletions.
2 changes: 1 addition & 1 deletion dpc-admin/Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ group :development do
gem 'simplecov', '<= 0.17'
# Spring speeds up development by keeping your application running in the background. Read more: https://github.com/rails/spring
gem 'spring'
gem 'spring-watcher-listen', '~> 2.0.0'
gem 'spring-watcher-listen', '~> 2.1.0'

gem 'letter_opener'
end
Expand Down
8 changes: 4 additions & 4 deletions dpc-admin/Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -440,10 +440,10 @@ GEM
simplecov-html (0.10.2)
simpleidn (0.2.1)
unf (~> 0.1.4)
spring (2.1.1)
spring-watcher-listen (2.0.1)
spring (4.1.3)
spring-watcher-listen (2.1.0)
listen (>= 2.7, < 4.0)
spring (>= 1.2, < 3.0)
spring (>= 4)
sprockets (4.2.1)
concurrent-ruby (~> 1.0)
rack (>= 2.2.4, < 4)
Expand Down Expand Up @@ -555,7 +555,7 @@ DEPENDENCIES
sidekiq_alive (~> 2.1.5)
simplecov (<= 0.17)
spring
spring-watcher-listen (~> 2.0.0)
spring-watcher-listen (~> 2.1.0)
sprockets-rails (>= 3.4.2)
truemail
turbolinks (~> 5)
Expand Down
2 changes: 1 addition & 1 deletion dpc-admin/config/environments/test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
# Settings specified here will take precedence over those in config/application.rb.

config.cache_classes = false
config.action_view.cache_template_loading = true
config.action_view.cache_template_loading = false

# Do not eager load code on boot. This avoids loading your whole application
# just for the purpose of running a single test. If you are using a tool that
Expand Down
2 changes: 1 addition & 1 deletion dpc-portal/Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ group :development do
# Version 0.18 has a breaking change for sonarqube
gem 'simplecov', '<= 0.17'
gem 'spring'
gem 'spring-watcher-listen', '~> 2.0.0'
gem 'spring-watcher-listen', '~> 2.1.0'
end

group :test do
Expand Down
8 changes: 4 additions & 4 deletions dpc-portal/Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -481,10 +481,10 @@ GEM
simplecov-html (0.10.2)
simpleidn (0.2.1)
unf (~> 0.1.4)
spring (2.1.1)
spring-watcher-listen (2.0.1)
spring (4.1.3)
spring-watcher-listen (2.1.0)
listen (>= 2.7, < 4.0)
spring (>= 1.2, < 3.0)
spring (>= 4)
sprockets (4.2.1)
concurrent-ruby (~> 1.0)
rack (>= 2.2.4, < 4)
Expand Down Expand Up @@ -604,7 +604,7 @@ DEPENDENCIES
sidekiq_alive (~> 2.1.5)
simplecov (<= 0.17)
spring
spring-watcher-listen (~> 2.0.0)
spring-watcher-listen (~> 2.1.0)
truemail
tzinfo-data
uglifier (>= 1.3.0)
Expand Down
2 changes: 1 addition & 1 deletion dpc-web/Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ group :development do
gem 'web-console', '>= 4.2.0'
gem 'listen', '~> 3.5'
gem 'spring'
gem 'spring-watcher-listen', '~> 2.0.0'
gem 'spring-watcher-listen', '~> 2.1.0'

gem 'rubocop', '>= 1.12.0', require: false
gem 'rubocop-performance', '>= 1.10.2', require: false
Expand Down
8 changes: 4 additions & 4 deletions dpc-web/Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -437,10 +437,10 @@ GEM
simplecov-html (0.10.2)
simpleidn (0.2.1)
unf (~> 0.1.4)
spring (2.1.1)
spring-watcher-listen (2.0.1)
spring (4.1.3)
spring-watcher-listen (2.1.0)
listen (>= 2.7, < 4.0)
spring (>= 1.2, < 3.0)
spring (>= 4)
sprockets (4.2.1)
concurrent-ruby (~> 1.0)
rack (>= 2.2.4, < 4)
Expand Down Expand Up @@ -546,7 +546,7 @@ DEPENDENCIES
sidekiq_alive (~> 2.1.5)
simplecov (<= 0.17)
spring
spring-watcher-listen (~> 2.0.0)
spring-watcher-listen (~> 2.1.0)
sprockets-rails (>= 3.4.2)
truemail
tzinfo-data
Expand Down
2 changes: 1 addition & 1 deletion dpc-web/config/environments/test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
# test suite. You never need to work with it otherwise. Remember that
# your test database is "scratch space" for the test suite and is wiped
# and recreated between test runs. Don't rely on the data there!
config.cache_classes = true
config.cache_classes = false

# Do not eager load code on boot. This avoids loading your whole application
# just for the purpose of running a single test. If you are using a tool that
Expand Down

0 comments on commit d87f9c5

Please sign in to comment.