[WNMGDS-3191] Box Content Component #3419
Open
+487
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack-ryan-nava-pbc
added
Impacts: Core
jack-ryan-nava-pbc
requested review from
pwolfert,
kim-cmsds,
tamara-corbalt,
andream-cmsds and
sophia-cmsds
packages/design-system/src/components/BoxContent/BoxContent.tsx
Outdated
Show resolved
Hide resolved
…rough automated testing (#3407) * Add a new astro project that specifically installs React 17 * Add a similar project for React 18 * Add VRTs for the two react projects so our automated testing suite will validate those versions * Update readme * Let's just leave this project alone for now * Move the web components template into the new `_shared` folder
* Initial commit * Update import path for define to use core design system module within monorepo. * Adds onClickLinkAnalytics handling * Adds unit tests * Adds exclude list to tsconfig.json * Adds an alias for relative path to define in webpack config. * Adds an import to react in ds-simple-footer.test.tsx * Adds react as an import to ds-accordion and ds-alert test and storybook files. * Add snapshots * Adds storybook-doc snapshot * Remove exclude list in tsconfig.json * Adds default values for argTypes * Updates storybook-docs snap * Revert out of scope changes. * Revert out of scope changes, part 2 * We no longer need to export define from index.ts * Removes setTimeout from useEffect in storybook template. * Adds website info argtype to storybook file, updates storybook-doc snapshot
|
Noting here that forced colors mode is now supported: 
|
… throw error at runtime if missing props
| if (author) { | ||
| return `${author} `; | ||
| } | ||
| if (!citation && !author) { |
There was a problem hiding this comment.
Is this a bit heavy handed???
There was a problem hiding this comment.
Yes, I think so. There are a few examples (ChoiceList) where warnings are defined like so:
if (process.env.NODE_ENV !== 'production') {
if (props.type !== 'checkbox' && props.choices.length === 1) {
console.warn(
`[Warning]: Use type="checkbox" for components with only one choice. A single radio button is disallowed because it prevents users from deselecting the field.`
);
}
}
kim-cmsds
reviewed
Feb 11, 2025
| className?: string; | ||
| } | ||
|
|
||
| export type BoxQuotationProps = RequireAtLeastOne<MinimumBoxQuotationProps, 'citation' | 'author'>; |
There was a problem hiding this comment.
This is neat! I wonder if it's worth adding an note in the MinimumBoxQuotationProps that either author or citation is required?
There was a problem hiding this comment.
Good call! Yes that is a good idea.
kim-cmsds
reviewed
Feb 11, 2025
packages/design-system/src/components/BoxContent/BoxQuotation.tsx
Outdated
Show resolved
Hide resolved
… update docs snapshot
tamara-corbalt
approved these changes
Feb 12, 2025
|
Moving this to draft until content review is complete and design is finalized. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
How to test
Demo Branch
Note: This is a pull request to solicit feedback on initial approach and ways to proceed. The final pull request will address the following items in addition to feedback gathered here.
propsare explainedChecklist
[WNMGDS-####] Titleor [NO-TICKET] if this is unticketed work.Type(only one) label for this PR, if it is a breaking change, label should only beType: BreakingImpacts, multiple can be selected.