-
Notifications
You must be signed in to change notification settings - Fork 87
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
NO TICKET - Resolution of several build, start and test warnings (#1552)
* updates prop references to tsx files as jsx files for these no longer exist * updates caniuse definitions for latest browsers solving npx browser update warning on build * Updates functions to allow for undefined props (they accept none) solving docgen warning * updates ellipses component definition to allow for empty props solving docgen warning (it has no props) * allow deBrokerName to be undefined to allow for fallback functionality to work, solves test warning as well * resolves build error recommending flex-end instead of end * componentWillMount is deprecated, change guidelines to reflect use of componentDidMount * NavigationMenu was using the deprecated Hamburger icon, changed to use MenuIconThin solving test warning * button variation 'secondary' doesn't exit on button types, changed to transparent to match dialog close button for h.gov, also updated title to heading which was causing the heading to not be displayed at all previously, fixes several test warnings * simpler way to do this, and updating privacy button size to use default * fixes for linting errors
- Loading branch information
Forrest Baer
authored
Feb 1, 2022
1 parent
8cafc13
commit bc2ccec
Showing
11 changed files
with
24 additions
and
29 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 4 additions & 2 deletions
6
packages/design-system/src/components/Pagination/Ellipses.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,11 @@ | ||
import React from 'react'; | ||
|
||
export default function Ellipses(): React.ReactElement { | ||
const Ellipses: React.FC<unknown> = (props) => { | ||
return ( | ||
<li> | ||
<span className="ds-c-pagination__overflow">…</span> | ||
</li> | ||
); | ||
} | ||
}; | ||
|
||
export default Ellipses; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters