[WNMGDS-765] Remove duplicate SR content in UsaBanner (#1797)

Icon title is duplicate content. Make it aria-hidden
CMSgov · Jun 2, 2022 · 8117503 · 8117503
1 parent eb357d9
commit 8117503
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 19 deletions.
diff --git a/packages/design-system/src/components/UsaBanner/UsaBanner.tsx b/packages/design-system/src/components/UsaBanner/UsaBanner.tsx
@@ -153,13 +153,8 @@ export const UsaBanner: React.FunctionComponent<UsaBannerProps> = (props: UsaBan
               <strong>{t('usaBanner.httpsHeaderText')}</strong>
               <br />
               {t('usaBanner.httpsAText')}
-              <strong> {t('usaBanner.httpsLockText')} </strong> ({' '}
-              <LockIcon
-                className="ds-c-usa-banner__lock-image"
-                title={t('usaBanner.httpsLockText')}
-                ariaHidden={false}
-              />{' '}
-              ) {t('usaBanner.httpsOrText')}
+              <strong> {t('usaBanner.httpsLockText')} </strong>{' '}
+              <LockIcon className="ds-c-usa-banner__lock-image" /> {t('usaBanner.httpsOrText')}
               <strong> {t('usaBanner.httpsText')} </strong>
               {t('usaBanner.httpsDetailText')}
             </p>

diff --git a/packages/design-system/src/components/UsaBanner/__snapshots__/UsaBanner.test.jsx.snap b/packages/design-system/src/components/UsaBanner/__snapshots__/UsaBanner.test.jsx.snap
@@ -111,26 +111,16 @@ exports[`UsaBanner renders correctly 1`] = `
               lock
                
             </strong>
-             (
              
             <svg
-              aria-hidden="false"
-              aria-labelledby="icon-6__title"
+              aria-hidden="true"
               class="ds-c-icon ds-c-icon--lock ds-c-usa-banner__lock-image"
               focusable="false"
               id="icon-6"
-              role="img"
               viewBox="0 0 52 64"
               xmlns="http://www.w3.org/2000/svg"
-            >
-              <title
-                id="icon-6__title"
-              >
-                lock
-              </title>
-            </svg>
+            />
              
-            ) 
             or
             <strong>