Skip to content

Commit

Permalink
[NO-TICKET] Fix release script not bumping versions in private packag…
Browse files Browse the repository at this point in the history
…es (#2987)

This recent change was incorrect, so revert

If we ignore all private packages during the bump, we're actually failing to bump the version of the design system packages in the dependencies for those private packages, which means that the doc site won't get the new version of the design system, and neither will the examples. I guess the tradeoff is that we have to choose an option for those private packages while we're going through the bump workflow
  • Loading branch information
pwolfert authored Mar 22, 2024
1 parent d28a95b commit 1caab93
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion scripts/release.ts
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ async function undoLastCommit() {
async function bumpVersions() {
console.log(c.green('Bumping package versions for release...'));
const preBumpHash = getCurrentCommit();
shI('./node_modules/.bin/lerna', ['version', '--no-push', '--no-private', '--exact']);
shI('./node_modules/.bin/lerna', ['version', '--no-push', '--exact']);
const postBumpHash = getCurrentCommit();

if (preBumpHash === postBumpHash) {
Expand Down

0 comments on commit 1caab93

Please sign in to comment.