-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BB2-1728: Proof of concept for C4DIC implementation #90
Draft
jimmyfagan
wants to merge
27
commits into
main
Choose a base branch
from
feature/c4dic
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p (debugpy issue with python3.11) changes
…fd.cms.gov, hack client config ENV=LOCAL: replace localhost with host IP e.g. 192.168.0.104 to workround a connect issue...
…ntained C4DIC Org, render coverage info using C4DIC Color Palette extension etc.
…feature-branch jimfuqian/BB2-3280 Update POC frontend for C4DIC according to designs from FIGMA
* First pass of edits * Render logo and bcg * Fix layout, add contact, addl info, etc * Remove some unneeded data fields * Adjustments from self-review
* First pass of edits * Render logo and bcg * Fix layout, add contact, addl info, etc * Remove some unneeded data fields * Adjustments from self-review * Updates to C4DIC
* Upgrade ds library, adjust contract id for part c/d, minor formatting adjustments * Revert ds update
* Upgrade ds library, adjust contract id for part c/d, minor formatting adjustments * Revert ds update * Adjustments to C4DIC POC * Add default data and adjust spacing for vertical alignment * Changes from self-review
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
BB2-1728
What Does This PR Do?
This PR provides a proof of concept for a front-end application that could make use of C4DIC implementation in BB2. Many of the changes here include reading from C4DIC resources, and populating a new tab on the sample client for the Digital Insurance Card rendering. There are various style and typescript changes to go along with that. Much of this was work was done by primarily backend engineers, so there is likely much room for refactoring.
Additionally, some sample data for c4dic was added to allow for this to be tested with default data without a functioning BB2 server running.
Future work would include:
Corresponding changes to the web server can be viewed at this draft PR.
What Should Reviewers Watch For?
If you're reviewing this PR, please check for these things in particular:
Are there any changes here that were helpful for the prototyping, but which aren't useful in the long term?
Validation
I would recommend setting
useDefaultDataButton
inpatientData.tsx
totrue
, runningdocker-compose up -d --build
, and then going to http://localhost:3000/, clickingLoad default data
, and navigating to the insurance card tab.