Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix footer link for Plain Writing #184

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Fix footer link for Plain Writing #184

merged 1 commit into from
Sep 14, 2023

Conversation

greg-pf
Copy link
Contributor

@greg-pf greg-pf commented Sep 14, 2023

🎫 Ticket

https://jira.cms.gov/browse/BCDA-xxx

🛠 Changes

Fixed a broken link in the footer to the plain writing guide.

ℹ️ Context for reviewers

Clicking the "Plain Writing" link in the footer, brings the user to a 404 page
Screenshot 2023-09-14 at 14 30 56
Screenshot 2023-09-14 at 14 30 20

✅ Acceptance Validation

The updated link directs to
Screenshot 2023-09-14 at 14 28 19

🔒 Security Implications

  • This PR adds a new software dependency or dependencies.
  • This PR modifies or invalidates one or more of our security controls.
  • This PR stores or transmits data that was not stored or transmitted before.
  • This PR requires additional review of its security implications for other reasons.

If any security implications apply, add Jason Ashbaugh (GitHub username: StewGoin) as a reviewer and do not merge this PR without his approval.

@greg-pf greg-pf marked this pull request as ready for review September 14, 2023 18:34
@greg-pf
Copy link
Contributor Author

greg-pf commented Sep 14, 2023

I clicked through the other links in the footer as well. All land on the expected pages.

Copy link
Contributor

@kyeah kyeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@greg-pf greg-pf merged commit e5f4511 into master Sep 14, 2023
1 check passed
@greg-pf greg-pf deleted the greg-pf-patch-1 branch September 14, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants