Skip to content

Commit

Permalink
Fix CI/CD failing on Golangci-lint timeout (#175)
Browse files Browse the repository at this point in the history
## 🎫 Ticket

n/a

## 🛠 Changes

added timeout arg to golangci-lint under `lint` in the makefile.

## ℹ️ Context for reviewers

CI/CD failing when running make-lint.

## ✅ Acceptance Validation

Build and Package pipeline run #4167 successful with changes.

## 🔒 Security Implications

- [ ] This PR adds a new software dependency or dependencies.
- [ ] This PR modifies or invalidates one or more of our security
controls.
- [ ] This PR stores or transmits data that was not stored or
transmitted before.
- [ ] This PR requires additional review of its security implications
for other reasons.

If any security implications apply, add Jason Ashbaugh (GitHub username:
StewGoin) as a reviewer and do not merge this PR without his approval.
  • Loading branch information
laurenkrugen-navapbc authored May 8, 2024
1 parent b0bcd04 commit d15f06c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ package:
-v ${PWD}:/go/src/github.com/CMSgov/bcda-ssas-app packaging $(version)

lint:
docker-compose -f docker-compose.test.yml run --rm tests golangci-lint -e SA1029 -v run ./...
docker-compose -f docker-compose.test.yml run --rm tests golangci-lint -e SA1029 --timeout 10m0s -v run ./...
docker-compose -f docker-compose.test.yml run --rm tests gosec ./...

# The following vars are available to tests needing SSAS admin credentials; currently they are used in smoke-test-ssas, postman-ssas, and unit-test-ssas
Expand Down

0 comments on commit d15f06c

Please sign in to comment.