BCDA-7212: Update Delete 204 error to 404

ssas/service/admin/api.go

@@ -308,7 +308,7 @@ func deleteGroup(w http.ResponseWriter, r *http.Request) {
 	err := ssas.DeleteGroup(r.Context(), id)
 	if err != nil {
 		logger.Errorf("failed to delete group; %s", err)
-		service.JSONError(w, http.StatusNoContent, http.StatusText(http.StatusNoContent), "failed to delete group")
+		service.JSONError(w, http.StatusNotFound, http.StatusText(http.StatusNotFound), "failed to delete group")
 		return
 	}
 

ssas/service/admin/router_test.go

@@ -109,7 +109,7 @@ func (s *RouterTestSuite) TestDeleteGroup() {
 	rr := httptest.NewRecorder()
 	s.router.ServeHTTP(rr, req)
 	res := rr.Result()
-	assert.Equal(s.T(), http.StatusNoContent, res.StatusCode)
+	assert.Equal(s.T(), http.StatusNotFound, res.StatusCode)
 }
 
 func (s *RouterTestSuite) TestPostSystem() {

test/postman_test/SSAS.postman_collection.json

@@ -293,16 +293,16 @@
 			"response": []
 		},
 		{
-			"name": "admin delete group, 204",
+			"name": "admin delete group, 404",
 			"event": [
 				{
 					"listen": "test",
 					"script": {
 						"id": "95ce3470-8202-4e9f-b4f6-4fe36a09cb0d",
 						"exec": [
-							"pm.test(\"response is 204 and no content\", function () {",
-							"    pm.response.to.have.status(204);",
-							"    pm.response.to.have.body('{\"error\":\"No Content\",\"error_description\":\"failed to delete group\"}',)",
+							"pm.test(\"response is 404 and not found\", function () {",
+							"    pm.response.to.have.status(404);",
+							"    pm.response.to.have.body('{\"error\":\"Not Found\",\"error_description\":\"failed to delete group\"}',)",
 							"});"
 						],
 						"type": "text/javascript"