Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLT-725 Updating postgres version for test containers #1422

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

oluwolenpbc
Copy link
Contributor

🎫 Ticket

https://jira.cms.gov/browse/PLT-725

🛠 Changes

To update test containers from postgres 11 to 16

ℹ️ Context

We have updated the postgres databases to 16.4 and we need to update our test to reflect the same version.

🧪 Validation

The e2e and unit test being successful will validate these changes.

@oluwolenpbc oluwolenpbc requested a review from a team as a code owner December 5, 2024 15:57
gsf
gsf previously approved these changes Dec 12, 2024
Copy link
Member

@gsf gsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gsf gsf dismissed their stale review December 12, 2024 18:47

See unusual error in integration test: CoverageCheckIntegrationTest.verifyCoverage_whenCoverageUnstable_fail:262 Expected gov.cms.ab2d.worker.processor.coverage.CoverageVerificationException to be thrown, but nothing was thrown.

@gsf
Copy link
Member

gsf commented Dec 12, 2024

Confirmed with ab2d team that the error is a known issue.

@oluwolenpbc oluwolenpbc merged commit 136251a into main Dec 12, 2024
7 of 9 checks passed
@oluwolenpbc oluwolenpbc deleted the PLT-725 branch December 12, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants