Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLT-746 Fix if statement in "promote" workflow #1415

Merged
merged 2 commits into from
Nov 4, 2024
Merged

PLT-746 Fix if statement in "promote" workflow #1415

merged 2 commits into from
Nov 4, 2024

Conversation

christopher-maboh
Copy link
Contributor

@christopher-maboh christopher-maboh commented Nov 4, 2024

🎫 Ticket

PLT-746

🛠 Changes

"fi" was added at the end of set environment variable statement

ℹ️ Context

ab2d team is trying to deploy some code to "prod-test" and looks like there are errors with existing code syntax in the. "promote" work flow .

🧪 Validation

Link to a successful manually trigger
https://github.com/CMSgov/ab2d/actions/runs/11666218254

@christopher-maboh christopher-maboh requested a review from gsf November 4, 2024 14:24
@christopher-maboh christopher-maboh requested a review from a team as a code owner November 4, 2024 14:24
.github/workflows/promote.yml Outdated Show resolved Hide resolved
@mjburling mjburling requested review from gsf and mjburling November 4, 2024 16:28
Copy link
Member

@gsf gsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gsf gsf changed the title PLT-746: existing code syntax in the. "promote" work flow PLT-746 Fix if statement in "promote" workflow Nov 4, 2024
Copy link
Contributor

@ildesenesence ildesenesence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to make sure we have ab2d-prod-test images for this to find, but this code fix looks good

@gsf gsf merged commit b7f5262 into main Nov 4, 2024
8 of 9 checks passed
@gsf gsf deleted the PLT-746 branch November 4, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants