PLT-695: Update AB2D prod-test ECR tag to avoid overlap with prod #1408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsf
reviewed
Oct 24, 2024
gsf
approved these changes
Oct 25, 2024
|
And please add steps that will be taken to validate to the Validation section. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
PLT-695
🛠 Changes
promote workflow updated to tag prod-test env images with the "ab2d-prod-test" prefix.
ℹ️ Context
The current tagging of ab2d-east-prod and ab2d-east-prod-test images causes issues. ECR lifecycle policies are based on prefixes. Essentially, a policy on the ab2d-east-prod prefix will include ab2d-east-prod-test images in its count and may delete all prod images older than any new prod-test images.
🧪 Validation
Check Workflow Execution:
Confirm that the workflow ran successfully in GitHub Actions.
Confirm Image Tags:
Go to the Amazon ECR repository in the AWS console.
Verify that the images have new tags (e.g., ab2d-prod-test-latest, ab2d-sbx-latest, etc., depending on the environment).
Run Deployment:
Trigger the deployment pipeline for the environment where this workflow was tested.
Confirm that the deployment succeeds without errors.
Check Logs for Any Issues:
Review logs from GitHub Actions and AWS CloudWatch for any error messages.
Verify Application Functionality:
Access the application (in the test or production environment as appropriate) to ensure it’s working correctly with the newly tagged images.