AB2D-6315 address AB2D unit test and integration test issues #1403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rwolfe-Nava
reviewed
Oct 22, 2024
| <version>0.0.1-SNAPSHOT</version> | ||
| <type>test-jar</type> | ||
| <scope>test</scope> | ||
| </dependency> | ||
| </dependencies> |
There was a problem hiding this comment.
Just wanted to check if this is needed, or if this is something leftover from when you were testing?
There was a problem hiding this comment.
I believe, I need this
Rwolfe-Nava
reviewed
Oct 22, 2024
coverage/src/test/java/gov/cms/ab2d/coverage/service/CoverageServiceImplTest.java
Outdated
Show resolved
Hide resolved
Rwolfe-Nava
reviewed
Oct 22, 2024
coverage/src/test/java/gov/cms/ab2d/coverage/service/CoverageServiceImplTest.java
Outdated
Show resolved
Hide resolved
Rwolfe-Nava
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/AB2D-6315
🛠 Changes
Mocked PropertyService in unit and integration tests
ℹ️ Context
In migrating the AB2D unit and integration tests from Jenkins to GitHub Actions we are still seeing flakiness with the "Cannot access properties service, using default database value" and "Cannot find the property maintenance.mode" errors.
🧪 Validation
Failed main branch https://github.com/CMSgov/ab2d/actions/runs/11355072772/job/31583682078#step:8:23490
This branch: https://github.com/CMSgov/ab2d/actions/runs/11448554170/job/31852335578