PLT-655 Add workflows to promote images and release app #1397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsf
reviewed
Sep 26, 2024
.github/workflows/promote.yml
Outdated
|
|
||
| jobs: | ||
| promote: | ||
| runs-on: self-hosted |
There was a problem hiding this comment.
This can run on ubuntu-latest since it doesn't rely on anything in our internal network.
gsf
reviewed
Sep 26, 2024
gsf
changed the title
gsf
reviewed
Oct 3, 2024
gsf
reviewed
Oct 3, 2024
.github/workflows/release.yml
Outdated
| id-token: write | ||
|
|
||
| jobs: | ||
| # Promote and Deploy to prod-test. We do not have api job deploy job for prod-test because we only deploy to worker for prod-test |
There was a problem hiding this comment.
You can still drop promote-prod-test-api below. And this line can be simplified
Suggested change
| # Promote and Deploy to prod-test. We do not have api job deploy job for prod-test because we only deploy to worker for prod-test | |
| # Promote and Deploy to prod-test, which only includes worker |
Co-authored-by: Sean Fern <[email protected]>
gsf
reviewed
Oct 3, 2024
.github/workflows/promote.yml
Outdated
| options: | ||
| - api | ||
| - worker | ||
| #These are the job permissions |
There was a problem hiding this comment.
No comment needed here, just a blank line to visually separate from triggers
.github/workflows/release.yml
Outdated
| with: | ||
| environment: prod-test | ||
| module: api | ||
| secrets: inherit |
There was a problem hiding this comment.
The promote-prod-test-api job is not needed
gsf
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/PLT-655
🛠 Changes
A new workflow to promote images up environments
ℹ️ Context
This is to push out and release our images to all our environments in github actions so we can move away from jenkins.
🧪 Validation
See run at https://github.com/CMSgov/ab2d/actions/runs/11150069080 for successful promote and deploy.