[AB2D-6305] - Implement a fix for job cancel polling response #1395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rwolfe-Nava
changed the title
christopher-maboh
force-pushed
the
ab2d-6305-implement-fix-for-job-canceled-polling
branch
3 times, most recently
from
e3a78bb to
15a2d84
Compare
Rwolfe-Nava
force-pushed
the
ab2d-6305-implement-fix-for-job-canceled-polling
branch
from
13a0705 to
af84e91
Compare
feralearthman
approved these changes
Oct 1, 2024
api/src/main/java/gov/cms/ab2d/api/controller/common/StatusCommon.java
Outdated
Show resolved
Hide resolved
Rwolfe-Nava
deleted the
ab2d-6305-implement-fix-for-job-canceled-polling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/AB2D-6305
🛠 Changes
Added a case to the switch statement in StatusCommon for when a job is in canceled status. (Previously this just went to the default case which was returning a 500 error).
Added a function to get and create a proper response object for when status is canceled as outlined in [FHIR bulk data export guidelines]https://build.fhir.org/ig/HL7/bulk-data/export.html
ℹ️ Context
AB2D fails part of Version 0.10.0 of the Inferno Bulk Data Access Test Kit Specificallly, test 2.3.3.02. We get a failure when requesting the status of a job which has been cancled. The test is looking for a 404 response, but we instead return a 500.
🧪 Validation
To be deployed and tested on IMPL (WIP)