Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AB2D-6303 Get CapabilityStatement without bearer token #1394

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Conversation

feralearthman
Copy link
Contributor

🎫 Ticket

https://jira.cms.gov/browse/AB2D-6303

🛠 Changes

Reordered antMatchers in SecurityConfig so that authExceptions come first.
Expanded the authExceptions for metadata from "/metadata" to "**/metadata" so that it works with v1 and v2. Added a /metadata clause to shouldBePublic.

ℹ️ Context

In order to conform with the Bulk Data IG (and pretty much any server IG) it should be possible to get a CapabilityStatement from the /metadata endpoint without having a bearer token.

🧪 Validation

Deployed branch to IMPL and checked to see that you can get a CapabilityStatement from the /metadata endpoint for both v1 and v2 by using Postman.

@feralearthman feralearthman requested a review from a team as a code owner September 13, 2024 15:55
@feralearthman
Copy link
Contributor Author

You can test using this curl command:
curl --location 'https://impl.ab2d.cms.gov/api/v2/fhir/metadata'
--header 'Accept: application/json'

Copy link
Contributor

@Rwolfe-Nava Rwolfe-Nava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Tested as well and it worked for me. Nice job!

Just make sure you rebase off of 'main' branch then before merging.

@feralearthman feralearthman merged commit 1f1a2de into main Sep 19, 2024
8 checks passed
@feralearthman feralearthman deleted the AB2D-6303 branch September 19, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants