Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove PCA variable computation #79

Merged
merged 1 commit into from
Aug 2, 2019

Conversation

clelange
Copy link
Contributor

@clelange clelange commented Jul 24, 2019

This is part of #78

Changes proposed in this pull-request:

  • remove calculation of all PCA and shower shape variables using MultiClusters

To be done:

  • discuss whether to remove the electrons as well since they are also built from MultiClusters, which are not up-to-date.
  • if merged, also update production tools templates

@jkiesele
Copy link
Contributor

+1

@clelange clelange merged commit 1bfa825 into CMS-HGCAL:master Aug 2, 2019
@clelange clelange deleted the remove_electron_reco branch August 2, 2019 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants