Update HGCAL rechit producer and add dEdx #170
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Excellent - thanks a lot! |
…rlap Strip overlap check for different product ID
Due to 32-bit range for sourceIDs, linear vector for mapping all possible ranges would be too large, therefore this class uses std:map (supposed to be ROOT compatible). Also, it does one big allocation instead of multiple small ones, but total data size need to be known upfront (which will be the case in DAQ input source). std::vector<std::byte> is used to wrap this, but we could also just use standard C++ array allocation. - add interface and unit test - start from classdef = 2. Setting 1 reports strange error about mismatch with -1 - SLink definitions are moved to a header in DataFormats
- two new conversion modules
Muon skims for the 2025 light-ion runs
Fix Jacobian for linefit in Brokenline.
- removed unused variables - updated a comment
…acros Merged SoAView into SoALayout and added heterogeneous deepCopy for PortableCollections
…5_June25 [L1T] Implementing sector based mode 7 promotion in EMTF for Run 3 2025
Ordering of module calls in begin/end/Job/Stream changed.
- fix missing ngtScouting modifier
…M unit test, use scouting rho
- This call was interfering with fits in other modules - Fixed memory leak - Avoid unnecessary extra cloning
- only attempt fit if have 3 non-zero bins - improved memory handling - use a TH1F rather than a MonitorElement as a temporary
This allows inheriting classes with fillDescriptions to be able to add the additional paramters.
These two modules were found to depend on histograms created by other modules in the harvester step
These are needed for workflows 145.408 and 136.731.
[SIM] Minor code update for future use of GPU
The FinalWaitTask is more robust than doing a while loop over the tbb_group::wait call. Also added SAFE_REQUIRE to protect the call to REQUIRE in more places.
Improve the Phase 1 pixel raw to cluster heterogeneous algorithm: - for each group of duplicate pixels, keep one and discard the rest; - fix the numer of nearest neighbours after duplicate removal; - include the last pixel of each module in the output; - remove unnecessary synchronisation.
There was a race where if the queue was empty right when the running task finished and the task sets m_taskChosen and see that the queue is empty and right then a new task is added and that thread sees m_taskChosen was set, then neither threads will start the next task.
Improve the Phase-1 pixel raw to cluster
…hing_fix Fix the list of modules in regional digi morphing
Removed call to TH1::SetDefaultSumw2 found in harvesting step
Add needed dependencies between some DQMEDHarvesters
Disable HIP/ROCm device-side error tests
Fix race condition in SerialTaskQueue
…2025 simulation geometry description
Run3-gex189 Make appropriate corrections to include the missing GE11 chamber in the 2025 simulation geometry description
Add NeNe to photon flux options for pythia.
stahlleiton
force-pushed
the
dev/hackathon_dEdx
branch
from
f1c9efc to
7a4912b
Compare
stahlleiton
force-pushed
the
dev/hackathon_dEdx
branch
from
7a4912b to
4329422
Compare
|
Superseded by cms-sw#48606. Also see https://gitlab.cern.ch/hgcal-dpg/hgcal-comm/-/issues/60. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
37 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
This PR updates the HGCAL rechit producer to be consistent with TICL and testbeam data, and it also add the dEdx correction for calculating the energy.
PR validation:
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
@IzaakWN @pfs