Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve library linking #180

Merged
merged 2 commits into from
Mar 11, 2025
Merged

Improve library linking #180

merged 2 commits into from
Mar 11, 2025

Conversation

arahlin
Copy link
Member

@arahlin arahlin commented Mar 10, 2025

  • Use private links for libraries that are specific to one module
  • Separate linking of Boost::python and Boost::iostreams
  • Remove explicit links to private libraries in exported cmake config

@arahlin
Improve library linking
56da889 
* Use private links for libraries that are specific to one module
* Separate linking of Boost::python and Boost::iostreams
* Remove explicit links to private libraries in exported cmake config
@arahlin arahlin requested review from tskisner and nwhitehorn March 10, 2025 01:13
@arahlin arahlin self-assigned this Mar 10, 2025
@arahlin
Copy link
Member Author

arahlin commented Mar 10, 2025

@tskisner not sure if this PR will make your life easier or not, but thought I'd tag you as an FYI.

@arahlin arahlin merged commit 8ebade6 into master Mar 11, 2025
2 checks passed
@arahlin arahlin deleted the lib_link_fixes branch March 11, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwhitehorn nwhitehorn nwhitehorn approved these changes

@tskisner tskisner Awaiting requested review from tskisner

Assignees

@arahlin arahlin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arahlin @nwhitehorn