Better G3Reader.tell() method #172
Closed
+56
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arahlin
force-pushed
the
istream_counter
branch
from
a3270bf to
6536635
Compare
Implement a byte counter as a boost istream filter to avoid buffering in the kernel. This should speed up read IO for frame indexing.
arahlin
force-pushed
the
istream_counter
branch
from
6536635 to
9a2e6b0
Compare
nwhitehorn
reviewed
Jan 23, 2025
nwhitehorn
reviewed
Jan 23, 2025
| G3Reader(std::vector<std::string> filenames, int n_frames_to_read = -1, | ||
| float timeout = -1., bool track_filename = false, | ||
| size_t buffersize = 1024*1024); | ||
| size_t buffersize = 1024*1024, bool counter = false); |
There was a problem hiding this comment.
Does counter = true cause a measurable performance drop? Or can we just make it always be on, the way it is for the writer?
There was a problem hiding this comment.
Testing actually indicates that this counter introduces a measurable performance drop, so we may need a different approach here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a byte counter as a boost istream filter to avoid buffering in the kernel. This should speed up read IO for frame indexing.