Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Json optional data path #198

Merged
merged 9 commits into from
Jun 26, 2023
Merged

Json optional data path #198

merged 9 commits into from
Jun 26, 2023

Conversation

christopher-wild
Copy link
Contributor

Related to issue 187.

I think the best way to handle directly providing a Dataframe rather than a path to data is to treat the data_path as optional.

Which it already is, so this adds a check to assert that one of the methods for providing data has been done

@github-actions
Copy link

github-actions bot commented Jun 22, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 26 0 1.26s
✅ PYTHON pylint 26 0 4.77s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #198 (e390c3e) into main (45cb719) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #198   +/-   ##
=======================================
  Coverage   95.22%   95.22%           
=======================================
  Files          20       20           
  Lines        1381     1383    +2     
=======================================
+ Hits         1315     1317    +2     
  Misses         66       66           
Impacted Files Coverage Δ
...usal_testing/specification/metamorphic_relation.py 98.19% <ø> (ø)
causal_testing/json_front/json_class.py 98.82% <100.00%> (+0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa90884...e390c3e. Read the comment docs.

@christopher-wild christopher-wild marked this pull request as ready for review June 26, 2023 10:43
@christopher-wild
Copy link
Contributor Author

christopher-wild commented Jun 26, 2023

I wanted to update the docs to include this feature, then ended up writing a lot of extra JSON Frontend docs, which ideally should have been a separate PR..

@christopher-wild christopher-wild merged commit d673d0a into main Jun 26, 2023
@christopher-wild christopher-wild deleted the json_optional_data_path branch April 4, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants