-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Json optional data path #198
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Codecov Report
@@ Coverage Diff @@
## main #198 +/- ##
=======================================
Coverage 95.22% 95.22%
=======================================
Files 20 20
Lines 1381 1383 +2
=======================================
+ Hits 1315 1317 +2
Misses 66 66
Continue to review full report in Codecov by Sentry.
|
I wanted to update the docs to include this feature, then ended up writing a lot of extra JSON Frontend docs, which ideally should have been a separate PR.. |
Related to issue 187.
I think the best way to handle directly providing a Dataframe rather than a path to data is to treat the data_path as optional.
Which it already is, so this adds a check to assert that one of the methods for providing data has been done