Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3175 Moving usings to GlobalUsing.cs #3186

Merged
merged 10 commits into from
Oct 22, 2024
Merged

#3175 Moving usings to GlobalUsing.cs #3186

merged 10 commits into from
Oct 22, 2024

Conversation

Metal-Mighty
Copy link
Contributor

@Metal-Mighty Metal-Mighty commented Aug 22, 2024 •
edited
Loading

Description

What's new?

  • Moves all usings to GlobalUsings.cs and _Imports.razor
  • Some class-specific usings are still in their respective files

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@Metal-Mighty Metal-Mighty self-assigned this Aug 22, 2024
@Metal-Mighty Metal-Mighty added .NET Pull requests that update .net code refactoring Restructure the source code so as to improve operation with labels Aug 22, 2024
@Metal-Mighty Metal-Mighty added this to the v6.0 milestone Aug 22, 2024
@Metal-Mighty Metal-Mighty linked an issue Aug 22, 2024 that may be closed by this pull request
Task: Group all using lines in unique GlobalUsings.cs files in the projects #3175
Closed
@Metal-Mighty
Move usings to GlobalUsings.cs and _Imports.razor
3b453d7
@Metal-Mighty
Move conflicted usings back to files
799fc5f
@Metal-Mighty
Merge branch 'main' of github.com:CGI-FR/IoT-Hub-Portal into task/317…
482b371 
…5-regroup-usings

# Conflicts:
#	src/IoTHub.Portal.Application/Managers/IDeviceModelImageManager.cs
#	src/IoTHub.Portal.Application/Mappers/EdgeDeviceProfile.cs
#	src/IoTHub.Portal.Application/Services/IDeviceModelService.cs
#	src/IoTHub.Portal.Application/Services/IEdgeModelService.cs
#	src/IoTHub.Portal.Client/Pages/EdgeDevices/CreateEdgeDevicePage.razor
#	src/IoTHub.Portal.Client/Pages/EdgeModels/CreateEdgeModelsPage.razor
#	src/IoTHub.Portal.Client/Pages/EdgeModels/EdgeModelListPage.razor
#	src/IoTHub.Portal.Infrastructure/ConfigHandlerBase.cs
#	src/IoTHub.Portal.Infrastructure/DevelopmentConfigHandler.cs
#	src/IoTHub.Portal.Infrastructure/Managers/AwsDeviceModelImageManager.cs
#	src/IoTHub.Portal.Infrastructure/Managers/DeviceModelImageManager.cs
#	src/IoTHub.Portal.Infrastructure/Mappers/DeviceModelMapper.cs
#	src/IoTHub.Portal.Infrastructure/Mappers/LoRaDeviceModelMapper.cs
#	src/IoTHub.Portal.Infrastructure/ProductionAWSConfigHandler.cs
#	src/IoTHub.Portal.Infrastructure/ProductionAzureConfigHandler.cs
#	src/IoTHub.Portal.Infrastructure/Providers/AzureDeviceRegistryProvider.cs
#	src/IoTHub.Portal.Infrastructure/Services/AwsDeviceModelService.cs
#	src/IoTHub.Portal.Infrastructure/Services/EdgeModelService.cs
#	src/IoTHub.Portal.Infrastructure/Services/LoRaWanManagementService.cs
#	src/IoTHub.Portal.Infrastructure/Startup/AzureServiceCollectionExtension.cs
#	src/IoTHub.Portal.Infrastructure/Startup/IServiceCollectionExtension.cs
#	src/IoTHub.Portal.MySql/Migrations/PortalDbContextModelSnapshot.cs
#	src/IoTHub.Portal.Server/Controllers/v1.0/DeviceConfigurationsController.cs
#	src/IoTHub.Portal.Server/Controllers/v1.0/DeviceModelControllerBase.cs
#	src/IoTHub.Portal.Server/Controllers/v1.0/DeviceModelPropertiesControllerBase.cs
#	src/IoTHub.Portal.Server/Controllers/v1.0/DeviceModelsController.cs
#	src/IoTHub.Portal.Server/Controllers/v1.0/DevicesControllerBase.cs
#	src/IoTHub.Portal.Server/Controllers/v1.0/EdgeDevicesController.cs
#	src/IoTHub.Portal.Server/Controllers/v1.0/LoRaWAN/LoRaWANConcentratorsController.cs
#	src/IoTHub.Portal.Server/Controllers/v1.0/LoRaWAN/LoRaWANDeviceModelsController.cs
#	src/IoTHub.Portal.Server/Controllers/v1.0/LoRaWAN/LoRaWANDevicesController.cs
#	src/IoTHub.Portal.Server/Controllers/v1.0/SettingsController.cs
#	src/IoTHub.Portal.Server/Services/DeviceModelService.cs
#	src/IoTHub.Portal.Shared/Models/v1.0/DeviceModelDto.cs
#	src/IoTHub.Portal.Shared/Models/v1.0/IDeviceModel.cs
#	src/IoTHub.Portal.Shared/Models/v1.0/IoTEdgeDevice.cs
#	src/IoTHub.Portal.Shared/Models/v1.0/IoTEdgeListItem.cs
#	src/IoTHub.Portal.Shared/Models/v1.0/IoTEdgeModelListItem.cs
#	src/IoTHub.Portal.Tests.Unit/Client/Dialogs/EdgeModels/AwsGreengrassComponentDialogTests.cs
#	src/IoTHub.Portal.Tests.Unit/Client/Pages/Configurations/EdgeModule/ModuleDialogTests.cs
#	src/IoTHub.Portal.Tests.Unit/Client/Pages/DevicesModels/DeviceModelDetailsPageTests.cs
#	src/IoTHub.Portal.Tests.Unit/Client/Pages/EdgeDevices/CreateEdgeDevicePageTest.cs
#	src/IoTHub.Portal.Tests.Unit/Client/Pages/EdgeDevices/EdgeDeviceDetailPageTests.cs
#	src/IoTHub.Portal.Tests.Unit/Client/Pages/EdgeModels/CreateEdgeModelsPageTest.cs
#	src/IoTHub.Portal.Tests.Unit/Client/Pages/EdgeModels/EdgeModelDetailPageTest.cs
#	src/IoTHub.Portal.Tests.Unit/Client/Pages/EdgeModels/SystemModuleDialogTest.cs
#	src/IoTHub.Portal.Tests.Unit/Client/Services/DeviceModelsClientServiceTests.cs
#	src/IoTHub.Portal.Tests.Unit/Client/Services/EdgeModelClientServiceTest.cs
#	src/IoTHub.Portal.Tests.Unit/Client/Services/LoRaWanDeviceModelsClientServiceTests.cs
#	src/IoTHub.Portal.Tests.Unit/Infrastructure/Managers/DeviceModelImageManagerTest.cs
#	src/IoTHub.Portal.Tests.Unit/Infrastructure/Mappers/DeviceModelMapperTests.cs
#	src/IoTHub.Portal.Tests.Unit/Infrastructure/Mappers/DeviceTwinMapperTests.cs
#	src/IoTHub.Portal.Tests.Unit/Infrastructure/Mappers/EdgeDeviceMapperTest.cs
#	src/IoTHub.Portal.Tests.Unit/Infrastructure/Mappers/LoRaDeviceModelMapperTests.cs
#	src/IoTHub.Portal.Tests.Unit/Infrastructure/Mappers/LoRaDeviceTwinMapperTests.cs
#	src/IoTHub.Portal.Tests.Unit/Infrastructure/ProductionAWSConfigHandlerTests.cs
#	src/IoTHub.Portal.Tests.Unit/Infrastructure/ProductionAzureConfigHandlerTests.cs
#	src/IoTHub.Portal.Tests.Unit/Infrastructure/Providers/AzureDeviceRegistryProviderTests.cs
#	src/IoTHub.Portal.Tests.Unit/Infrastructure/Services/AwsDeviceModelServiceTests.cs
#	src/IoTHub.Portal.Tests.Unit/Server/Controllers/v1.0/AdminControllerTests.cs
#	src/IoTHub.Portal.Tests.Unit/Server/Controllers/v1.0/DeviceConfigurationsControllerTests.cs
#	src/IoTHub.Portal.Tests.Unit/Server/Controllers/v1.0/DeviceModelControllerBaseTests.cs
#	src/IoTHub.Portal.Tests.Unit/Server/Controllers/v1.0/DeviceModelPropertiesControllerTests.cs
#	src/IoTHub.Portal.Tests.Unit/Server/Controllers/v1.0/DeviceModelsControllerTests.cs
#	src/IoTHub.Portal.Tests.Unit/Server/Controllers/v1.0/DeviceTagSettingsControllerTest.cs
#	src/IoTHub.Portal.Tests.Unit/Server/Controllers/v1.0/DevicesControllerTests.cs
#	src/IoTHub.Portal.Tests.Unit/Server/Controllers/v1.0/EdgeDevicesControllerTests.cs
#	src/IoTHub.Portal.Tests.Unit/Server/Controllers/v1.0/EdgeModelsControllerTest.cs
#	src/IoTHub.Portal.Tests.Unit/Server/Controllers/v1.0/LoRaWAN/LoRaWANCommandsControllerTests.cs
#	src/IoTHub.Portal.Tests.Unit/Server/Controllers/v1.0/LoRaWAN/LoRaWANConcentratorsControllerTest.cs
#	src/IoTHub.Portal.Tests.Unit/Server/Controllers/v1.0/LoRaWAN/LoRaWANDeviceModelsControllerTest.cs
#	src/IoTHub.Portal.Tests.Unit/Server/Controllers/v1.0/LoRaWAN/LoRaWANDevicesControllerTests.cs
#	src/IoTHub.Portal.Tests.Unit/Server/Controllers/v1.0/LoRaWAN/LoRaWANFrequencyPlansControllerTests.cs
#	src/IoTHub.Portal.Tests.Unit/Server/Controllers/v1.0/SettingsControllerTest.cs
#	src/IoTHub.Portal.Tests.Unit/Server/Services/DeviceModelServiceTests.cs
#	src/IoTHub.Portal.Tests.Unit/Server/Services/DeviceServiceTests.cs
#	src/IoTHub.Portal.Tests.Unit/Server/Services/EdgeDeviceServiceTest.cs
#	src/IoTHub.Portal.Tests.Unit/Server/Services/EdgeModelServiceTest.cs
@Metal-Mighty
Update usings following merge from main
d9c245b
@Metal-Mighty
Fix merge issues
c8ec251
@Metal-Mighty
Fixing code and unit tests
507f787
@Metal-Mighty
Fix build issue
480e80c
@codecov Codecov
Copy link

codecov bot commented Oct 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 78.57143% with 6 lines in your changes missing coverage. Please review.

Project coverage is 83.12%. Comparing base (fb16310) to head (cea69e7).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...nfrastructure/Services/AwsExternalDeviceService.cs 42.85% 4 Missing ⚠️
...b.Portal.Client/Pages/Devices/DeviceListPage.razor 0.00% 0 Missing and 1 partial ⚠️
....Client/Services/DeviceTagSettingsClientService.cs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3186      +/-   ##
==========================================
- Coverage   83.27%   83.12%   -0.15%     
==========================================
  Files         327      327              
  Lines       12422    12428       +6     
  Branches      980      980              
==========================================
- Hits        10344    10331      -13     
- Misses       1785     1807      +22     
+ Partials      293      290       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Metal-Mighty Metal-Mighty marked this pull request as ready for review October 22, 2024 09:07
@Metal-Mighty Metal-Mighty requested a review from a team as a code owner October 22, 2024 09:07
@Metal-Mighty Metal-Mighty enabled auto-merge (rebase) October 22, 2024 09:07
auto-merge was automatically disabled October 22, 2024 09:29

Rebase failed

@Metal-Mighty Metal-Mighty merged commit 0362e0b into main Oct 22, 2024
6 checks passed
@Metal-Mighty Metal-Mighty deleted the task/3175-regroup-usings branch October 22, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TLeoDev TLeoDev TLeoDev approved these changes

Assignees

@Metal-Mighty Metal-Mighty

Labels
.NET Pull requests that update .net code refactoring Restructure the source code so as to improve operation with
Projects
IoT Hub Portal
Status: 🚀 Ready
Milestone
v6.0
Development

Successfully merging this pull request may close these issues.

Task: Group all using lines in unique GlobalUsings.cs files in the projects
2 participants
@Metal-Mighty @TLeoDev