RBAC - REST APIs #2773
Merged
RBAC - REST APIs #2773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TLeoDev
changed the title
kbeaugrand
requested changes
Jan 8, 2024
kbeaugrand
requested changes
Jan 15, 2024
src/IoTHub.Portal.Infrastructure/Services/RRAC/RoleManagementService.cs
Outdated
Show resolved
Hide resolved
kbeaugrand
requested changes
Jan 15, 2024
src/IoTHub.Portal.Application/Services/RoleManagementService.cs
Outdated
Show resolved
Hide resolved
added 7 commits
April 11, 2024 14:05
…User logic implemented in services
added 7 commits
April 24, 2024 11:32
…e unused action...)
Metal-Mighty
requested changes
May 31, 2024
There was a problem hiding this comment.
Additionally to requested changes on specific files, please also extend all your unit tests to cover situations where the tested feature doesn't work and returns an error, in order to make sure we handle errors properly, with the correct errors and error codes, etc
src/IoTHub.Portal.Server/Controllers/v1.0/DashboardController.cs
Outdated
Show resolved
Hide resolved
src/IoTHub.Portal.Server/Controllers/v1.0/DashboardController.cs
Outdated
Show resolved
Hide resolved
src/IoTHub.Portal.Server/Controllers/v1.0/SettingsController.cs
Outdated
Show resolved
Hide resolved
| var existingName = await this.groupRepository.GetByNameAsync(group.Name); | ||
| if (existingName is not null) | ||
| { | ||
| throw new ResourceAlreadyExistsException($"The Group tis the name {group.Name} already exist !"); |
| var existingName = await this.userRepository.GetByNameAsync(user.Name); | ||
| if (existingName is not null) | ||
| { | ||
| throw new ResourceAlreadyExistsException($"The User tis the name {user.Name} already exist !"); |
| var user = await userRepository.GetByIdAsync(id); | ||
| if (user is null) | ||
| { | ||
| throw new ResourceNotFoundException($"The User with the id {id} that you want to delete does'nt exist !"); |
| } | ||
|
|
||
| /*[Test] | ||
| public async Task DeleteAccessControlShouldReturnExpectedBehavior() |
There was a problem hiding this comment.
Would be better if this test was uncommented and working :)
There was a problem hiding this comment.
I made the changes, its working now
TLeoDev
commented
Jun 4, 2024
| return Ok(await groupManagementService.DeleteGroup(id)); | ||
| try | ||
| { | ||
| var result =await groupManagementService.DeleteGroup(id); |
There was a problem hiding this comment.
The code in the try is never reached
Metal-Mighty
requested changes
Jun 14, 2024
Metal-Mighty
requested changes
Jul 18, 2024
| @@ -130,7 +130,7 @@ private static IServiceCollection ConfigureImageBlobStorage(this IServiceCollect | |||
| var serviceClient = new BlobServiceClient(configuration.AzureStorageAccountConnectionString); | |||
| var container = serviceClient.GetBlobContainerClient(opts.ImageContainerName); | |||
|
|
|||
| _ = container.SetAccessPolicy(PublicAccessType.Blob); | |||
There was a problem hiding this comment.
This shouldn't be commented in production code since it only impacts us on our test infrastructure (and will be handled in #3076)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What's new?
What kind of change does this PR introduce?