Open
Conversation
The point is that in cell bases, we store facet info at great memory cost given that only a small fraction of the facets are surface (i.e., part of the complex / restricted) facets.
WIP: available with both cell member API and map API
- Get rid of the caches: squat the value -2 - Re-order class member to use as few bytes as possible
I need access to the C3T3 member functions. This could be restricted to surface facet criteria only, but might as well do it for everything.
- Do not use a base_base - Avoid the sliver cache: all values are positive, so squat -2 as a cache. - Do not use surface info arrays, use the C3T3 maps - Re-order for byte padding
7532b99 to
38626ba
Compare
1bd040f to
b5357bf
Compare
And fix it for cases where storage is within the hash map
24ae5a4 to
1c7556c
Compare
Member
|
MSVC2017 has a compilation issue: |
Member
|
Testsuite looks good in Successfully tested in CGAL-6.2-Ic-160 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
heaptrack | vtune | usr/bin/time
TODO: